Follow-up for ThirdPartyResources examples #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andronat
reviewed
Nov 16, 2016
|
|
||
| // Only required to authenticate against GKE clusters | ||
| _ "k8s.io/client-go/1.5/plugin/pkg/client/auth/gcp" | ||
| _ "k8s.io/client-go/plugin/pkg/client/auth/gcp" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
Can you also get rid of this var? I think you don't need it to be global.
| // The code below is used only to work around a known problem with third-party | ||
| // resources and ugorji. If/when these issues are resolved, the code below | ||
| // should no longer be required. | ||
| // Some of the code below is used only to work around a known problem with |
There was a problem hiding this comment.
Ugorji said the behavior is expected and I couldn't find any better work around, so the comment needs to be revised. How about this:
The code below is used only to work around a known problem with third-party resources and the ugorji codec (see: https://github.com/ugorji/go/issues/178). You will not need the workaround after the upstream stop using ugorji codec (tracking issue: https://github.com/kubernetes/kubernetes/issues/36120).
Sorry for keeping back and forth on this.
|
The issues are already fixed. Closing. Thanks, @wfarr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29:
I believe this should address all the feedback offered in #29
This change is