use array instead of map for supported resources

kubernetes · May 11, 2022 · e48b6a2 · e48b6a2
1 parent 151d4f9
commit e48b6a2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/pkg/controllers/options/resources.go b/pkg/controllers/options/resources.go
@@ -16,6 +16,6 @@ const (
  Instance string = "instance"
 )
 
-var SupportedResources = map[string]string{
- "instance": Instance,
+var SupportedResources = []string{
+ Instance,
 }
diff --git a/pkg/controllers/options/tagging_controller.go b/pkg/controllers/options/tagging_controller.go
@@ -38,12 +38,16 @@ func (o *TaggingControllerOptions) Validate() error {
  }
 
  for _, r := range o.Resources {
- if _, ok := SupportedResources[r]; !ok {
- resources := []string{}
- for r, _ := range SupportedResources {
- resources = append(resources, r)
+ found := false
+
+ for _, resource := range SupportedResources {
+ if r == resource {
+ found = true
  }
- return fmt.Errorf("%s is not a supported resource. Current supported resources %v", r, resources)
+ }
+
+ if !found {
+ return fmt.Errorf("%s is not a supported resource. Current supported resources %v", r, SupportedResources)
  }
  }