Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecr-credential-provider: Fix warning about no region in image ref #1030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ecr-credential-provider: Fix warning about no region in image ref #1030

wants to merge 1 commit into from

Conversation

cartermckinnon
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

This log line is in the wrong place, should be when region == "" not region != "".

Which issue(s) this PR fixes:

Noticed in #1029

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cartermckinnon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@cartermckinnon
Copy link
Contributor Author

cartermckinnon commented Sep 26, 2024 •
edited
Loading

@mmerkes PTAL, I think you were the orig author

@cartermckinnon cartermckinnon mentioned this pull request Sep 26, 2024
Closed
@cartermckinnon
Copy link
Contributor Author

CI seems ill lately.

/retest

@kmala
Copy link
Member

kmala commented Sep 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2024
@kmala
Copy link
Member

kmala commented Sep 27, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@kishorj kishorj Awaiting requested review from kishorj

Assignees

@kmala kmala

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartermckinnon @k8s-ci-robot @kmala