Fix cloudbuild and simplify Makefile & cloudbuild #162
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
approved
nckturner
force-pushed
the
fix-and-simplify-build
branch
2 times, most recently
from
27a4233
to
c5ad5ae
Compare
|
/assign @andrewsykim |
|
@nckturner: GitHub didn't allow me to request PR reviews from the following users: ayberk. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Remove cloudbuild logic from Makefile - Fix ldflags version - Use gcr.io/cloud-builders/docker for cloudbuild (tangentially, this should also fix the cloudbuild build, which was failing because of what appeared to be an env var collision between the Makefile and the build container with $IMAGE).
nckturner
force-pushed
the
fix-and-simplify-build
branch
from
c5ad5ae
to
c66ad67
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(tangentially, this should also fix the cloudbuild
build, which was failing because of what appeared
to be an env var collision between the Makefile
and the build container with $IMAGE).
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Simplifies cloudbuild and Makefile (should fix it in the process, but we will need to merge it to see).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: