Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelogs #365

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Changelogs #365

merged 1 commit into from
Jun 16, 2022

Conversation

nckturner
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Changelogs for recent releases: v1.20.0, v1.21.0, v1.22.1, v1.23.1

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2022
@k8s-ci-robot
Copy link
Contributor

@nckturner: This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@nckturner
Copy link
Contributor Author

/hold
Wait until failing tests on 1.21, 1.20 are fixed before publishing updated versions in the table.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2022
This was referenced May 16, 2022
Merged
Merged
hakman
hakman reviewed May 16, 2022
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
@hakman
Copy link
Member

hakman commented May 20, 2022

@nckturner I think all releases are unblocked now and ready to be published.

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@nckturner
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@hakman
Copy link
Member

hakman commented May 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2022
hakman
hakman reviewed May 24, 2022
View reviewed changes
docs/README.md Outdated
| v1.20 | v1.20.0-alpha.0 |
| v1.24 | v1.24.0 |
| v1.23 | v1.23.1 |
| v1.22 | v1.22.1 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a v1.22.2 also? I don't see v1.22.1 tagged in http://gcr.io/k8s-staging-provider-aws/cloud-controller-manager

Suggested change
| v1.22 | v1.22.1 |
| v1.22 | v1.22.2 |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right... 😕

Copy link
Contributor Author

@nckturner nckturner May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness this appears to be what we have:

Version Staging tag Staging sha
v1.24.0 v1.24.0 sha256:9b1f6a6dd5de51cc30381187e0a3e236c6cebd34ca975074db3d4a3b0b2ca57c
v1.23.1 v1.23.1 sha256:96d591732ec106ba6b51595c10d66a68a141e4ef970af4e3d26bd9b042207ef3
v1.22.1 v20220513-v1.22.1 sha256:6bccf3047f081889313180d4548f7d28fc4e5c6efa84e0dc08887500a2ee507d
v1.21.1 v1.21.1 sha256:30359d1236c610bdc139953cbc7b6ff66198ce9db1ddc131570c5e439b069581
v1.21.0 - -
v1.20.1 v1.20.1 sha256:a5bfb84c5b6e6b6358f4b27b1029e7aafcece120cc2e9f34789a777f1f23d24b
v1.20.0 - -

So we need a 1.22.2, but the last 1.22 build seems to have done nothing (https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/cloud-provider-aws-push-images/1526857358146277376), not sure what's going on there.

Copy link
Contributor Author

@nckturner nckturner May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promote 1.22.2, 1.21.1, 1.20.1: kubernetes/k8s.io#3769

Copy link
Member

@hakman hakman May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the 1.22.2 tag in the staging repo. I think this is the correct job for that tag, so we are good to go with promotion to the stable repo:
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/cloud-provider-aws-push-images/1529394025990197248.

@nckturner
Copy link
Contributor Author

/assign @olemarkus

@olemarkus
Copy link
Member

Did I just see 1.22.3 released? Should this be updated as well?

@nckturner
Changelogs
eb53f88 
* v1.20.0
* v1.20.1
* v1.21.0
* v1.21.1
* v1.22.1
* v1.23.1
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2022
hakman
hakman approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9a6b247 into kubernetes:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@hakman hakman hakman approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@olemarkus olemarkus

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nckturner @k8s-ci-robot @hakman @olemarkus