Skip to content

use docker build to generate images(1.32 backport) #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

use docker build to generate images(1.32 backport) #830

merged 1 commit into from
Apr 10, 2025

Conversation

YifeiZhuang
Copy link
Contributor

backport of (#825)

@aojea @YifeiZhuang
use docker build to generate images (kubernetes#825)
bf66601 
Change-Id: I2c8839ba088342318ee93fb03527917f21a4aee5
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from justinsb and seans3 April 9, 2025 17:01
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 9, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 9, 2025
@mmamczur
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, YifeiZhuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2b5fa4c into kubernetes:release-1.32 Apr 10, 2025
7 checks passed
aojea
aojea reviewed Apr 10, 2025
View reviewed changes
Dockerfile
@@ -0,0 +1,16 @@
ARG GOARCH="amd64"

FROM golang:1.24 AS builder
Copy link
Member

@aojea aojea Apr 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be aware of kubernetes and golang versions relation, you can find the relation in this filel https://github.com/kubernetes/kubernetes/blob/master/.go-version in each branch https://github.com/kubernetes/kubernetes/blob/release-1.32/.go-version, it is 1.23.6 in 1.32 ... it is ok but sporadically there are changes in golang that can affect

ameukam
ameukam reviewed Apr 10, 2025
View reviewed changes
Dockerfile
@@ -0,0 +1,16 @@
ARG GOARCH="amd64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are fixing the architecture which breaks k8s cluster bootstrapping on T2A or C4A instances. cc @aojea

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar with image names, but I assume this is related to arm64, is it?

@YifeiZhuang YifeiZhuang mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@aojea aojea aojea left review comments

@justinsb justinsb Awaiting requested review from justinsb

@seans3 seans3 Awaiting requested review from seans3

Assignees

@mmamczur mmamczur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YifeiZhuang @k8s-ci-robot @mmamczur @ameukam @aojea