-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] Enable optional storageclasses. #2578
[cinder-csi-plugin] Enable optional storageclasses. #2578
Conversation
Hi @powellchristoph. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@powellchristoph: Before jumping into the code - you need to retain the release note box from the PR template: https://github.com/kubernetes/cloud-provider-openstack/blob/66624e34b1884781dca75f2ae6dc9736c0de9f28/.github/PULL_REQUEST_TEMPLATE.md |
I'm looking into chart lint failure. |
See #2582 for chart linting failure explanation. It's not fault of this patch, we'll fix it soon. /ok-to-test |
Ah, looks like you need to make EasyCLA happy. Just click "Details" in its test table row and follow the steps. |
I've followed the link and filled it out twice now. Its sent me the email. I'm not sure what else I'm supposed to do. And I've previously commited :( |
I'm not sure. We fixed the linting failure though. |
/easycla |
/approve Can you squash the commits before the final |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[cinder-csi-plugin] Enable Optional StorageClasses
What this PR does / why we need it:
If you enable the included storageclasses, you get both the
retain
anddelete
. This PR allows each class to be enabled individually.Which issue this PR fixes(if applicable):
na
Special notes for reviewers:
na
Release note: