[occm] fix e2e tests #2636
Merged
[occm] fix e2e tests #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
zetaab
commented
Sep 2, 2024
| @@ -101,7 +101,7 @@ function wait_for_service_address { | |||
|
|
|||
| end=$(($(date +%s) + ${TIMEOUT})) | |||
| while true; do | |||
| ipaddr=$(kubectl -n $NAMESPACE describe service ${service_name} | grep 'LoadBalancer Ingress' | awk -F":" '{print $2}' | tr -d ' ') | |||
| ipaddr=$(kubectl -n $NAMESPACE describe service ${service_name} | grep 'LoadBalancer Ingress' | awk '{print $3}') | |||
There was a problem hiding this comment.
the issue with this is, that starting from kubernetes 1.31 there is now extra information (VIP) or (Proxy) in the same line
There was a problem hiding this comment.
good catch ,thanks for the PR
|
cc @dulek |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kayrus
pushed a commit
to kayrus/cloud-provider-openstack
that referenced
this pull request
Sep 17, 2024
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Release 1.30.1 * Bump golangci to 1.61 * fix e2e tests (#2636) --------- Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: