Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] fix global config requirement for node-service #2678

Merged

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Sep 27, 2024

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #2677

Special notes for reviewers:

Release note:

[cinder-csi-plugin] fix global config requirement for node-service

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2024
@kayrus
Copy link
Contributor Author

kayrus commented Sep 27, 2024

/cherry-pick release-1.31

@k8s-infra-cherrypick-robot

@kayrus: once the present PR merges, I will cherry-pick it on top of release-1.31 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayrus could you add example of minimal cloud configuration for noClient usecase?

it seems that I am using

[BlockStorage]
bs-version=v3
ignore-volume-az=false
ignore-volume-microversion=false

@kayrus
Copy link
Contributor Author

kayrus commented Sep 30, 2024

could you add example of minimal cloud configuration

your example is fair enough

@zetaab
Copy link
Member

zetaab commented Sep 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2024
@dulek
Copy link
Contributor

dulek commented Oct 1, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 333a126 into kubernetes:master Oct 1, 2024
6 checks passed
@k8s-infra-cherrypick-robot

@kayrus: new pull request created: #2683

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
6 participants