Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] upgrade snapshot to v2.1.1 #974

Merged
merged 1 commit into from
Sep 3, 2020
Merged

[cinder-csi-plugin] upgrade snapshot to v2.1.1 #974

merged 1 commit into from
Sep 3, 2020

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Mar 16, 2020 •
edited by ramineni
Loading

The binaries affected:

IMPORTANT: Please also add the binary name in the title, e.g.
[openstack-cloud-controller-manager]: Add UDP protocol support
unless the PR affects multiple binaries.

  • openstack-cloud-controller-manager
  • cinder-csi-plugin
  • k8s-keystone-auth
  • client-keystone-auth
  • octavia-ingress-controller
  • manila-csi-plugin
  • manila-provisioner
  • magnum-auto-healer
  • barbican-kms-plugin

What this PR does / why we need it:
update snapshot side car container to v2.1.1

upgrade snapshot to v2.1.1

https://github.com/kubernetes-csi/external-snapshotter/releases
has a broken update when upgrade to 2.0.0

so the upgrade of the side car container including:
1) upgrade the version
2) honor the split of snapshot controller and snapshotter
3) update rbac
4) update example according to the v1beta1 definition

Which issue this PR fixes:
xref #951

Special notes for reviewers:

Release note:

[cinder-csi-plugin] updated external-snapshotter to v2.1.1

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2020
@jichenjc jichenjc changed the title upgrade snapshot to v2.0.1 WIP: upgrade snapshot to v2.0.1 Mar 16, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 16, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 16, 2020

Build failed.

@jichenjc jichenjc mentioned this pull request Mar 17, 2020
Closed
@jichenjc jichenjc force-pushed the update_snapshotter branch from cbb7d37 to 0cedeb7 Compare March 18, 2020 07:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2020
@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 18, 2020 •
edited
Loading

I am able to create containers and create snapshot:

# kubectl get pods --all-namespaces
NAMESPACE     NAME                            READY   STATUS    RESTARTS   AGE
kube-system   csi-cinder-controllerplugin-0   5/5     Running   0          12s
kube-system   csi-cinder-nodeplugin-l54m2     3/3     Running   0          12s
kube-system   kube-dns-74b889989-fngqk        3/3     Running   0          62s


# kubectl get volumesnapshots
NAME                READYTOUSE   SOURCEPVC           SOURCESNAPSHOTCONTENT   RESTORESIZE   SNAPSHOTCLASS          SNAPSHOTCONTENT                                    CREATIONTIME   AGE
new-snapshot-demo   true         pvc-snapshot-demo                           1Gi           csi-cinder-snapclass   snapcontent-90a2e460-76a5-4680-aa94-e6947bd492b3   15s            15s

openstack GUI


Name | Description | Size | Status | Group Snapshot | Volume Name | Actions
-- | -- | -- | -- | -- | -- | --
  | snapshot-90a2e460-76a5-4680-aa94-e6947bd492b3 | Created by OpenStack Cinder CSI driver | 1GiB | Available | - | pvc-f30f3a23-11e4-43d1-bc21-0ac1835b2324 |  

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 18, 2020

Build succeeded.

@jichenjc jichenjc force-pushed the update_snapshotter branch from 0cedeb7 to 93d99da Compare March 18, 2020 07:10
@jichenjc jichenjc changed the title WIP: upgrade snapshot to v2.0.1 upgrade snapshot to v2.0.1 Mar 18, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 18, 2020

Build succeeded.

@jichenjc jichenjc mentioned this pull request Mar 19, 2020
Merged
9 tasks
@jichenjc
Copy link
Contributor Author 

# kubectl describe pods csi-cinder-controllerplugin-0 -n kube-system | grep Image:
    Image:         quay.io/k8scsi/csi-attacher:v2.1.1
    Image:         quay.io/k8scsi/csi-provisioner:v1.5.0
    Image:          quay.io/k8scsi/snapshot-controller:v2.0.1
    Image:         quay.io/k8scsi/csi-resizer:v0.4.0
    Image:         jichenjc/cinder-csi-plugin:dev
# kubectl describe pods csi-cinder-nodeplugin-rlc9t -n kube-system | grep Image:
    Image:         quay.io/k8scsi/csi-node-driver-registrar:v1.2.0
    Image:         quay.io/k8scsi/csi-snapshotter:v2.0.1
    Image:         jichenjc/cinder-csi-plugin:dev

@jichenjc jichenjc force-pushed the update_snapshotter branch from 93d99da to 29e3764 Compare March 19, 2020 02:42
@jichenjc jichenjc changed the title upgrade snapshot to v2.0.1 upgrade snapshot to v2.0.1 and provisioner to v1.5.0 Mar 19, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 19, 2020

Build succeeded.

@jichenjc jichenjc force-pushed the update_snapshotter branch from c0ee367 to 142db64 Compare August 26, 2020 05:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2020
@jichenjc
Copy link
Contributor Author

@ramineni updated directly in this PR, replicate the rbac and image changes to charts

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@jichenjc
Copy link
Contributor Author

um... the helm charts seems dedicate to 1.18 release, note sure it's usable in master

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@ramineni
Copy link
Contributor

um... the helm charts seems dedicate to 1.18 release, note sure it's usable in master

@jichenjc you are right , missed it , all the values correspond to 1.18.0 which is bit confusing , ideally it should be latest on master . Unless the tag is latest we cant update it on par with manifests. We need a dedicate PR to update the charts , so we dont want to block this PR.
Note: I have slightly changed the release note

@jichenjc
Copy link
Contributor Author

@ramineni I will revert the chart update and submit again
the chart PR will submitted soon and might switch from 1.18 to master etc

@jichenjc
upgrade snapshot to v2.1.1
0b76519 
https://github.com/kubernetes-csi/external-snapshotter/releases
has a broken update when upgrade to 2.1.1

so the upgrade of the side car container including:
1) upgrade the version
2) honor the split of snapshot controller and snapshotter
3) update rbac
4) update example according to the v1beta1 definition

The helm chart is updated as well
@jichenjc jichenjc force-pushed the update_snapshotter branch from 142db64 to 0b76519 Compare August 26, 2020 07:18
@jichenjc
Copy link
Contributor Author

@ramineni please help to check again, thanks

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 26, 2020

Build succeeded.

@ramineni ramineni mentioned this pull request Sep 3, 2020
Closed
@lingxiankong
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 66b9eed into kubernetes:master Sep 3, 2020
jichenjc added a commit to jichenjc/cloud-provider-openstack that referenced this pull request Sep 7, 2020
@jichenjc
upgrade snapshot to v2.1.1 (kubernetes#974)
132982c 
https://github.com/kubernetes-csi/external-snapshotter/releases
has a broken update when upgrade to 2.1.1

so the upgrade of the side car container including:
1) upgrade the version
2) honor the split of snapshot controller and snapshotter
3) update rbac
4) update example according to the v1beta1 definition

The helm chart is updated as well
This was referenced Sep 8, 2020
Merged
Closed
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@jichenjc
upgrade snapshot to v2.1.1 (kubernetes#974)
3546d2d 
https://github.com/kubernetes-csi/external-snapshotter/releases
has a broken update when upgrade to 2.1.1

so the upgrade of the side car container including:
1) upgrade the version
2) honor the split of snapshot controller and snapshotter
3) update rbac
4) update example according to the v1beta1 definition

The helm chart is updated as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramineni ramineni ramineni requested changes

@anguslees anguslees Awaiting requested review from anguslees

@hogepodge hogepodge Awaiting requested review from hogepodge

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jichenjc @lingxiankong @ramineni @strigazi @k8s-ci-robot