Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-of-conduct.md #1414

Closed
chrislovecnm opened this issue Nov 18, 2017 · 12 comments · Fixed by #1457
Closed

code-of-conduct.md #1414

chrislovecnm opened this issue Nov 18, 2017 · 12 comments · Fixed by #1457
Assignees
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 18, 2017

We seem to reference the code-of-conduct but we do not actually have a file in here. https://github.com/kubernetes/kubernetes/blob/master/code-of-conduct.md

/assign @sarahnovotny

Any reason for that? It is part of the base template for Kubernetes GitHub projects.

@k8s-ci-robot
Copy link
Contributor

@chrislovecnm: GitHub didn't allow me to assign the following users: parispittman.

Note that only kubernetes members can be assigned.

In response to this:

We seem to reference the code-of-conduct but we do not actually have a file in here. https://github.com/kubernetes/kubernetes/blob/master/code-of-conduct.md

/assign @sarahnovotny @parispittman

Any reason for that? It is part of the base template for Kubernetes GitHub projects.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 18, 2017
@chrislovecnm chrislovecnm added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Nov 20, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 20, 2017
@chrislovecnm
Copy link
Contributor Author

/assign @parispittman

Does someone want me to PR? @dankohn who is the legal guru that lays this stuff out?

@xiangpengzhao
Copy link
Contributor

@dankohn who is the legal guru that lays this stuff out?

I'm not sure, but I guess @dankohn has some more contexts.

@dankohn
Copy link
Contributor

dankohn commented Dec 1, 2017

I believe this is working as designed. We want the K8s CoC to cite by reference the CNCF CoC, just as the other 13 CNCF-hosted projects do. That way, if and when we revise the CoC in the future, all CNCF projects will automatically be updated.

Of course, we won’t change the CoC without first getting buy-in from the maintainers of all of the projects.

Can we close the issue?

@chrislovecnm
Copy link
Contributor Author

we do not have the file @dankohn in this repo :)

@cblecker
Copy link
Member

cblecker commented Dec 1, 2017

You mean adding it to the kubernetes/community repo itself?

@chrislovecnm
Copy link
Contributor Author

correct we do not have the file in this repo, and we should ...

@chrislovecnm
Copy link
Contributor Author

Let me PR it and we can discuss on the PR ... 😆

@chrislovecnm
Copy link
Contributor Author

Hey my English was horrible on that comment, I am surprised anyone understood that comment

@chrislovecnm
Copy link
Contributor Author

@xiangpengzhao see #1457

@xiangpengzhao
Copy link
Contributor

@chrislovecnm haha, I believe I misunderstood around :)

k8s-github-robot pushed a commit that referenced this issue Dec 1, 2017
Automatic merge from submit-queue.

adding code-of-conduct.md

closes #1414

We do not have this file in this repo.

/assign @cblecker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants