Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Design Proposals Folder #918

Closed
3 tasks
grodrigues3 opened this issue Aug 15, 2017 · 5 comments · Fixed by kubernetes/kubernetes#52894, kubernetes/kubernetes#52897 or kubernetes/kubernetes#52995
Closed
3 tasks
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@grodrigues3
Copy link
Contributor

grodrigues3 commented Aug 15, 2017

The design proposals folder is getting a little out of hand, and we could do a few things to help improve it.

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 15, 2017
@smarterclayton
Copy link
Contributor

We talked about organization of design proposals on sig-arch and I had the todo of a structure proposal. I'm leery of per sig because we have many cross cutting proposals, but functional area is probably the best choice since we lack any other clear structure for team ownership.

I do think approval process for a proposal has a higher bar than code, since they touch on expansion of "what is kubernetes". I'd argue for fewer approvers or a model that requires several confirmations. We've described proposals in the same way others describe RFC, and that is not a "single yea" system.

@cblecker cblecker added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Aug 16, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2017
@grodrigues3
Copy link
Contributor Author

I do think approval process for a proposal has a higher bar than code, since they touch on expansion of "what is kubernetes". I'd argue for fewer approvers or a model that requires several confirmations.

@smarterclayton that makes total sense. Do you think we need automation for this (requires some thought) or can we rely on consensus (e.g. several confirmations) or existing leadership to resolve these disputes?

Functional area makes sense. What do you think about splitting out approved designs and proposals?

@grodrigues3
Copy link
Contributor Author

@kubernetes/sig-architecture-feature-requests

@smarterclayton
Copy link
Contributor

smarterclayton commented Aug 16, 2017 via email

@bgrant0607
Copy link
Member

Related: #651

@kubernetes kubernetes deleted a comment from k8s-github-robot Sep 1, 2017
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Sep 29, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in kubelet after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in kubelet after  kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Oct 14, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in kubeadm after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in kubeadm after kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Oct 24, 2017
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in api after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in api after kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```
sttts pushed a commit to sttts/apimachinery that referenced this issue Oct 24, 2017
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in api after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in api after kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```

Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
sttts pushed a commit to sttts/api that referenced this issue Oct 24, 2017
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in api after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in api after kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```

Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
sttts pushed a commit to sttts/apimachinery that referenced this issue Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in api after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in api after kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```

Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
sttts pushed a commit to sttts/api that referenced this issue Oct 26, 2017
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in api after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in api after kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```

Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
akhilerm pushed a commit to akhilerm/apimachinery that referenced this issue Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix broken links in api after moving proposals to subdirs

**What this PR does / why we need it**:
fix incorrect links in api after kubernetes/community#1010

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes  kubernetes/community#918

**Special notes for your reviewer**:
CC @bgrant0607
**Release note**:

```
NONE
```

Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
5 participants