-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize Design Proposals Folder #918
Organize Design Proposals Folder #918
Comments
We talked about organization of design proposals on sig-arch and I had the todo of a structure proposal. I'm leery of per sig because we have many cross cutting proposals, but functional area is probably the best choice since we lack any other clear structure for team ownership. I do think approval process for a proposal has a higher bar than code, since they touch on expansion of "what is kubernetes". I'd argue for fewer approvers or a model that requires several confirmations. We've described proposals in the same way others describe RFC, and that is not a "single yea" system. |
@smarterclayton that makes total sense. Do you think we need automation for this (requires some thought) or can we rely on consensus (e.g. several confirmations) or existing leadership to resolve these disputes? Functional area makes sense. What do you think about splitting out approved designs and proposals? |
@kubernetes/sig-architecture-feature-requests |
Up until now we haven't merged proposals that aren't approved. So we may
not need approved yet, but I could see how that might be desirable.
Possibly instead of sub folders, we could require better naming. We could
also have a deprecated / out of date proposals dir, although that can also
be managed by naming.
I think we don't know yet what the approval process will be officially, but
unofficially it is "you convince all the major stakeholders you're going to
impact that their concerns have addressed, you get a consensus on the
change to architecture from the people who usually complain about top level
architecture, and then you get merged when the affected sig reviewers sign
off". I suspect for proposals we don't quite want automation yet for
merging, but we do want automation for nagging and identifying impacted
parties and prettying it up into docs.
…On Wed, Aug 16, 2017 at 1:23 PM, grodrigues3 ***@***.***> wrote:
@kubernetes/sig-architecture-feature-requests
<https://github.com/orgs/kubernetes/teams/sig-architecture-feature-requests>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#918 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p5elfN4WkgfxVpNe4noqNAoSio2uks5sYyV0gaJpZM4O4Oxy>
.
|
Related: #651 |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in kubelet after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in kubelet after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ```
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in kubeadm after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in kubeadm after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ```
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in api after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in api after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ```
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in api after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in api after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ``` Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in api after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in api after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ``` Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in api after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in api after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ``` Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in api after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in api after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ``` Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
Automatic merge from submit-queue (batch tested with PRs 52556, 52897, 54342). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken links in api after moving proposals to subdirs **What this PR does / why we need it**: fix incorrect links in api after kubernetes/community#1010 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/community#918 **Special notes for your reviewer**: CC @bgrant0607 **Release note**: ``` NONE ``` Kubernetes-commit: e02d4a985554ceeff1f4456693f71b419df599f6
The design proposals folder is getting a little out of hand, and we could do a few things to help improve it.
The text was updated successfully, but these errors were encountered: