Update priority eviction docs #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
/approve |
k8s-ci-robot
added
the
lgtm
|
Automatic merge from submit-queue. |
|
/lgtm |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Oct 13, 2017
Automatic merge from submit-queue (batch tested with PRs 51840, 53542, 53857, 53831, 53702). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Kubelet Evictions take Priority into account Issue: #22212 This implements the eviction strategy documented here: kubernetes/community#1162, and discussed here: kubernetes/community#846. When priority is not enabled, all pods are treated as equal priority. This PR makes the following changes: 1. Changes the eviction ordering strategy to (usage < requests, priority, usage - requests) 2. Changes unit testing to account for this change in eviction strategy (including tests where priority is disabled). 3. Adds a node e2e test which tests the eviction ordering of pods with different priorities. /assign @dchen1107 @vishh cc @bsalamat @derekwaynecarr ```release-note Kubelet evictions take pod priority into account ```
MadhavJivrajani
pushed a commit
to MadhavJivrajani/community
that referenced
this pull request
Nov 30, 2021
Automatic merge from submit-queue. Update priority eviction docs After discussion with @dchen1107 and @bsalamat I think it would be simpler to start with a tiered eviction sorting rather than by using a function. See kubernetes#846 (review) for some of the rationale. This PR makes two changes: 1. Changes the release at which changes take effect to 1.9 (since implementation missed 1.8) 2. Changes the strategy from (usage > requests, func(priority, usage - requests)) to (usage > requests, priority, usage - requests) cc @dchen1107 @derekwaynecarr @vishh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with @dchen1107 and @bsalamat I think it would be simpler to start with a tiered eviction sorting rather than by using a function. See #846 (review) for some of the rationale.
This PR makes two changes:
cc @dchen1107 @derekwaynecarr @vishh