Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed anchor to ConfigMaps #1313

Closed
wants to merge 1 commit into from
Closed

Conversation

rettori
Copy link

@rettori rettori commented Nov 1, 2017

Removed ' ' to fix anchor to ConfigMaps example part.

Removed ' ' to fix anchor to ConfigMaps example part.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2017
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @rettori. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

cblecker commented Nov 1, 2017

/ok-to-test
/lgtm

Thanks for the PR! Please review #1313 (comment) for details on our CLA. Once you comment here that it's signed, this should auto-merge.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2017
@k8s-github-robot k8s-github-robot added the sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. label Nov 1, 2017
@cblecker
Copy link
Member

cblecker commented Nov 1, 2017

/retest

@xiangpengzhao
Copy link
Contributor

@cblecker seems like the anchors are generated by some tools? Maybe we should fix the tool when parsing this case.

* [Pod Spec with `ConfigMap` Example](#pod-spec-with-`configmap`-example)

@cblecker
Copy link
Member

@xiangpengzhao I'm not sure which tool is being used.

k8s-github-robot pushed a commit that referenced this pull request Dec 1, 2017
Automatic merge from submit-queue.

Fix anchor in pod-preset.md

Fixes #1313.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants