Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the minimum go version for release 1.11+ #2125

Merged
merged 1 commit into from
May 16, 2018
Merged

Add the minimum go version for release 1.11+ #2125

merged 1 commit into from
May 16, 2018

Conversation

warmchang
Copy link
Contributor

@warmchang warmchang commented May 3, 2018 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2018
@k8s-ci-robot k8s-ci-robot requested review from Phillels and spiffxp May 3, 2018 14:22
cblecker
cblecker requested changes May 3, 2018
View reviewed changes
contributors/devel/development.md Outdated
@@ -134,7 +134,9 @@ development environment, please [set one up](http://golang.org/doc/code.html).
| 1.5, 1.6 | 1.7 - 1.7.5 |
| 1.7 | 1.8.1 |
| 1.8 | 1.8.3 |
| 1.9+ | 1.9.1 |
| 1.9 | 1.9.2 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is go1.9.1: https://github.com/kubernetes/kubernetes/blob/release-1.9/hack/lib/golang.sh#L325

contributors/devel/development.md Outdated
@@ -134,7 +134,9 @@ development environment, please [set one up](http://golang.org/doc/code.html).
| 1.5, 1.6 | 1.7 - 1.7.5 |
| 1.7 | 1.8.1 |
| 1.8 | 1.8.3 |
| 1.9+ | 1.9.1 |
| 1.9 | 1.9.2 |
| 1.10 | 1.9.3 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is go1.9.1: https://github.com/kubernetes/kubernetes/blob/release-1.10/hack/lib/golang.sh#L329

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your opinion? For the 1.9 and 1.10 branches, only show the minimum go-lang version instead of the actual used of each branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be the minimum version for that branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I've modified and please check it.

@warmchang
Add the minimum go version for release 1.11+
234a909 
Signed-off-by: William Zhang <warmchang@outlook.com>
@warmchang warmchang changed the title Correct the go-lang version Add the minimum go version for release 1.11+ May 5, 2018
@warmchang
Copy link
Contributor Author

ping @cblecker

@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2018
cblecker
cblecker approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit a619b59 into kubernetes:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@Phillels Phillels Awaiting requested review from Phillels

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warmchang @cblecker @k8s-ci-robot