Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SECURITY_CONTACTS for k/community #2181

Merged
merged 1 commit into from
May 24, 2018

Conversation

cblecker
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 23, 2018
@wking
Copy link
Contributor

wking commented May 23, 2018

Looks good to me :). Can this PR or follow up work adjust our current docs to link to the new local file? When I asked about linking a local example here, @jessfraz expected this repo to not need its own SECURITY_CONTACTS. With the local example to link to, I think we can drop the current template reference, but I don't have a problem keeping it either if folks want to link to both the local example and the template.

@cblecker
Copy link
Member Author

No, I want to continue referencing the template project from the governance template.

@jessfraz
Copy link
Contributor

Thanks for being awesome :)

@wking
Copy link
Contributor

wking commented May 23, 2018

No, I want to continue referencing the template project from the governance template.

It doesn't have to be either/or, it can be both/and. For example:

  - Defined in [`SECURITY_CONTACTS`](/SECURITY_CONTACTS) files, this is only relevant to the root file in
    the repository, there is a template
    [here](https://github.com/kubernetes/kubernetes-template-project/blob/master/SECURITY_CONTACTS)

or:

  - Defined in `SECURITY_CONTACTS` files (like [this one](/SECURITY_CONTACTS)), this is only relevant to the root file in
    the repository, there is a template
    [here](https://github.com/kubernetes/kubernetes-template-project/blob/master/SECURITY_CONTACTS)

@cblecker
Copy link
Member Author

There's no need to reference the SECURITY_CONTACTS file in this repo from the template description. The authoritative location if someone is referencing the template is the template project. This file is irrelevant to the template.

@wking
Copy link
Contributor

wking commented May 23, 2018

There's no need to reference the SECURITY_CONTACTS file in this repo from the template description. The authoritative location if someone is referencing the template is the template project. This file is irrelevant to the template.

Ah, maybe I'm just getting confused by having project template docs in the sig-charter template. It looks like it's designed to cover sigs.yaml, but now some of the information is actually stored in external repositories (like OWNERS). So now I agree that we don't need a local OWNERS link, and am 100% on board with this PR as it stands. I'll file a separate PR to try and refocus the sig-charter template section on sigs.yaml.

@castrojo
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2018
@dims
Copy link
Member

dims commented May 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit b06ecd7 into kubernetes:master May 24, 2018
@cblecker cblecker deleted the sec-community branch May 24, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants