-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SECURITY_CONTACTS for k/community #2181
Conversation
Looks good to me :). Can this PR or follow up work adjust our current docs to link to the new local file? When I asked about linking a local example here, @jessfraz expected this repo to not need its own |
No, I want to continue referencing the template project from the governance template. |
Thanks for being awesome :) |
It doesn't have to be either/or, it can be both/and. For example: - Defined in [`SECURITY_CONTACTS`](/SECURITY_CONTACTS) files, this is only relevant to the root file in
the repository, there is a template
[here](https://github.com/kubernetes/kubernetes-template-project/blob/master/SECURITY_CONTACTS) or: - Defined in `SECURITY_CONTACTS` files (like [this one](/SECURITY_CONTACTS)), this is only relevant to the root file in
the repository, there is a template
[here](https://github.com/kubernetes/kubernetes-template-project/blob/master/SECURITY_CONTACTS) |
There's no need to reference the SECURITY_CONTACTS file in this repo from the template description. The authoritative location if someone is referencing the template is the template project. This file is irrelevant to the template. |
Ah, maybe I'm just getting confused by having project template docs in the sig-charter template. It looks like it's designed to cover |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: castrojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
No description provided.