Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KEP for cloud provider doc maintenance #2442

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Add KEP for cloud provider doc maintenance #2442

merged 1 commit into from
Jul 31, 2018

Conversation

d-nishi
Copy link
Contributor

@d-nishi d-nishi commented Jul 31, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jul 31, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2018
@andrewsykim
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2018
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

In general, I think a KEP is overkill documentation changes of this kind where the OWNERS are stakeholders in execution.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2018
@andrewsykim
Copy link
Member

A lot more to work to be done here but this is a good starting point.

@timothysc noted! We had agreed to use KEPs to standardize doc format across providers since we need to be coordinated for easier consumption from sig-docs. Maybe it is overkill but this is a good way for us to provide guidance to other subprojects (providers) on how to document things. We're happy to consider other approaches here :)!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2018
@k8s-ci-robot k8s-ci-robot merged commit 272e7b3 into kubernetes:master Jul 31, 2018
@andrewsykim
Copy link
Member

ref: kubernetes/kubernetes#66825

calebamiles pushed a commit to calebamiles/community that referenced this pull request Sep 5, 2018
Add KEP for cloud provider doc maintenance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants