Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added architecture tracking to sigs.yaml #2499

Merged
merged 1 commit into from
Aug 8, 2018
Merged

added architecture tracking to sigs.yaml #2499

merged 1 commit into from
Aug 8, 2018

Conversation

jdumars
Copy link
Member

@jdumars jdumars commented Aug 8, 2018

Reference: #2476

@jdumars jdumars added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. committee/steering Denotes an issue or PR intended to be handled by the steering committee. labels Aug 8, 2018
@jdumars jdumars requested a review from spiffxp August 8, 2018 19:25
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2018
@bgrant0607
Copy link
Member

Thanks. All of these subprojects are totally bogus, but this at least puts the link there.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 189d493 into kubernetes:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

@calebamiles calebamiles Awaiting requested review from calebamiles

Assignees

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdumars @bgrant0607 @k8s-ci-robot