Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create api-machinery charter.md #2927

Merged
merged 6 commits into from
Dec 5, 2018
Merged

Create api-machinery charter.md #2927

merged 6 commits into from
Dec 5, 2018

Conversation

maulin9
Copy link
Contributor

@maulin9 maulin9 commented Nov 12, 2018

As per the request, drafted SIG API Machinery charter file.

@maulin9
Create charter.md
6103df1 
As per the request, drafted SIG API Machinery charter file.
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @maulin9. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 12, 2018
@cblecker
Copy link
Member

@maulin9 A charter is a very detailed document created by the sig in question. An empty template isn't helpful in this situation.

If you want to get involved please have a look at our contributors guide: https://git.k8s.io/community/contributors/guide

/close

@cblecker cblecker closed this Nov 12, 2018
@maulin9
Copy link
Contributor Author

maulin9 commented Nov 12, 2018

@cblecker here is the template for creating charter.md file. https://github.com/kubernetes/community/edit/master/committee-steering/governance/sig-charter-template.md
I followed the instructions in the template.

deads2k
deads2k reviewed Nov 12, 2018
View reviewed changes
sig-api-machinery/charter.md Outdated


[sig-governance]: https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md
[sig-subprojects]: https://github.com/kubernetes/community/blob/master/sig-YOURSIG/README.md#subprojects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to fill this in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Verified with @lavalamp https://github.com/kubernetes/community/tree/master/sig-api-machinery is up to date so that should address last two lines.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with @lavalamp https://github.com/kubernetes/community/tree/master/sig-api-machinery is up to date so that should address last two lines.

YOURSIG doesn't need to be filled in?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

This should be:
https://github.com/kubernetes/community/blob/master/sig-api-machinery/README.md#subprojects

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

deads2k
deads2k reviewed Nov 12, 2018
View reviewed changes
sig-api-machinery/charter.md Outdated

### Subproject Creation

1. SIG Technical Leads
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might link like sig-auth https://github.com/kubernetes/community/blob/master/sig-auth/charter.md#subproject-creation

@deads2k
Copy link
Contributor

deads2k commented Nov 12, 2018

@maulin9 A charter is a very detailed document created by the sig in question. An empty template isn't helpful in this situation.

If you want to get involved please have a look at our contributors guide: https://git.k8s.io/community/contributors/guide

@cblecker I think this pull filled in values that match our existing readme.

/reopen

@k8s-ci-robot
Copy link
Contributor

@deads2k: Reopened this PR.

In response to this:

@maulin9 A charter is a very detailed document created by the sig in question. An empty template isn't helpful in this situation.

If you want to get involved please have a look at our contributors guide: https://git.k8s.io/community/contributors/guide

@cblecker I think this pull filled in values that match our existing readme.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Nov 12, 2018
@deads2k
Copy link
Contributor

deads2k commented Nov 12, 2018

@lavalamp

@lavalamp
Copy link
Member

Thanks, Maulin! CLA + fix comments & it's ready to go.

@maulin9
Copy link
Contributor Author

maulin9 commented Nov 12, 2018

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 12, 2018
@bgrant0607 bgrant0607 changed the title Create charter.md Create api-machinery charter.md Nov 13, 2018
@bgrant0607 bgrant0607 self-assigned this Nov 13, 2018
@bgrant0607
Copy link
Member

@cblecker Thanks. The Steering Committee has iterated on the SIG charter template and tried to minimize hard-to-maintain copy/paste text in it.

https://github.com/kubernetes/community/tree/master/committee-steering/governance

I'll work with the SIG on the charter.

@maulin9
Update charter.md
6da9a6b 
Removed WIP statement and added "Technical leads seeded by legacy SIG chairs from existing subproject owners"
@maulin9
Copy link
Contributor Author

maulin9 commented Nov 14, 2018

@lavalamp let me know if anything is needed merge the PR.

@yue9944882
Copy link
Member

/ok-to-test 😺

@yue9944882
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2018
@maulin9
Update charter.md
b7ab624 
Added bullets to scope list.  Added 'The informer libraries' to scope.  Added  'Client library releases' to ### Cross-cutting and Externally Facing Processes
@lavalamp
Copy link
Member

@maulin9 if you go to file view and scroll to the bottom I think you'll find a comment that github has been hiding from you :)

@maulin9
Update charter.md
64f7327 
Fixed the link to README.md.
bgrant0607
bgrant0607 reviewed Nov 23, 2018
View reviewed changes
sig-api-machinery/charter.md

#### Cross-cutting and Externally Facing Processes

Client library releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to link to a doc that describes the process

@maulin9
Updated charter.md
cc7f60b 
Removed scheduler from the scope as scheduler is the responsibility of SIG Scheduler.
@jdumars jdumars mentioned this pull request Nov 30, 2018
Closed
@spiffxp
Copy link
Member

spiffxp commented Dec 2, 2018

/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Dec 2, 2018
@bgrant0607
Copy link
Member

Looks like everything critical was resolved. Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 77c7fa3 into kubernetes:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@bgrant0607 bgrant0607 bgrant0607 left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maulin9 @k8s-ci-robot @cblecker @deads2k @lavalamp @bgrant0607 @yue9944882 @spiffxp