Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godep: add details on CNCF whitelist policy #3239

Closed
wants to merge 2 commits into from

Conversation

swinslow
Copy link
Contributor

@swinslow swinslow commented Feb 8, 2019

This PR includes the excellent writeup of the CNCF Whitelist Policy from @nikhita originally in #3231, along with some clarifying comments and edits. (Ref: kubernetes/steering#57 (comment))

(Apologies if there's another way I should have added this to #3231, rather than doing a new PR here!)

/cc @nikhita @dims @justaugustus
members involved in the sig-release licensing subproject

/cc @thockin @cblecker @sttts
dep-approvers

/sig release
/area licensing

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Feb 8, 2019
@k8s-ci-robot k8s-ci-robot added area/licensing size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swinslow
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jbeda

If they are not already assigned, you can assign the PR to them by writing /assign @jbeda in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/developer-guide Issues or PRs related to the developer guide sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2019
@swinslow
Copy link
Contributor Author

swinslow commented Feb 8, 2019

I note the comment from @justaugustus at #3231 (comment). I'm fine with moving this content to kubernetes/sig-release as he described and just linking to it from here, if that's preferred.

@justaugustus
Copy link
Member

@swinslow -- I'm going to close this and have us submit updates to @nikhita's PR instead, just so the conversation is one place.

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

@swinslow -- I'm going to close this and have us submit updates to @nikhita's PR instead, just so the conversation is one place.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swinslow
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants