Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds two sig-cluster-lifecycle projects #3818

Closed
wants to merge 1 commit into from

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jun 19, 2019

Signed-off-by: Chuck Ha chuckh@vmware.com

Adding two new subprojects. I will need the repos created before I can link to the owner files, unless I'm going about this the wrong way?

cc @detiber

edit: after this I can make an issue to make a repo that references this change

@k8s-ci-robot
Copy link
Contributor

Welcome @chuckha!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jun 19, 2019
sigs.yaml Outdated Show resolved Hide resolved
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just add these in based on where they will be in the future

sigs.yaml Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
@neolit123
Copy link
Member

/hold
/assign @timothysc

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chuckha
To complete the pull request process, please assign timothysc
You can assign the PR to them by writing /assign @timothysc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2019
Signed-off-by: Chuck Ha <chuckh@vmware.com>
@chuckha
Copy link
Contributor Author

chuckha commented Jun 20, 2019

@neolit123 can you explain the hold please? I don't mind that you added a hold but it would be nice to know why.

@detiber
Copy link
Member

detiber commented Jun 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

I can't speak for why the hold was added, but we usually merge the sigs.yaml PR after the repo has been created, just to be sure that the repos mentioned here really exist 😬

@chuckha
Copy link
Contributor Author

chuckha commented Jun 20, 2019

oh! thanks @nikhita I'll go open an issue to get the repos created, I thought this had to come first

@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

I thought this had to come first

There isn't a strict order or anything. It's actually nice to have this PR out and have the required lgtms already though. 😄

@neolit123
Copy link
Member

neolit123 commented Jun 20, 2019 via email

@chuckha
Copy link
Contributor Author

chuckha commented Jun 20, 2019

@neolit123 thank you for the clarification

@chuckha
Copy link
Contributor Author

chuckha commented Jun 20, 2019

Evidently this is the wrong place to make a PR. What I want is a new project owned by the Cluster API group which is part of sig cluster lifecycle -- I'll close this and open a PR in kubernetes/org and update Cluster API's owners files and use those.

@chuckha chuckha closed this Jun 20, 2019
@chuckha chuckha deleted the scl branch June 20, 2019 14:15
@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

/reopen

@chuckha can you update this to just the cluster-api-provider-docker repo?
Ref: kubernetes/org#938

@k8s-ci-robot
Copy link
Contributor

@nikhita: Failed to re-open PR: state cannot be changed. The scl branch has been deleted.

In response to this:

/reopen

@chuckha can you update this to just the cluster-api-provider-docker repo?
Ref: kubernetes/org#938

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

Oh lol, let's move to another PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants