-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds two sig-cluster-lifecycle projects #3818
Conversation
Welcome @chuckha! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just add these in based on where they will be in the future
/hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chuck Ha <chuckh@vmware.com>
@neolit123 can you explain the hold please? I don't mind that you added a hold but it would be nice to know why. |
/lgtm |
I can't speak for why the hold was added, but we usually merge the sigs.yaml PR after the repo has been created, just to be sure that the repos mentioned here really exist 😬 |
oh! thanks @nikhita I'll go open an issue to get the repos created, I thought this had to come first |
There isn't a strict order or anything. It's actually nice to have this PR out and have the required lgtms already though. 😄 |
Feel free to unhold if the creation was discussed on sig level.
…On Jun 20, 2019 16:46, "Nikhita Raghunath" ***@***.***> wrote:
I thought this had to come first
There isn't a strict order or anything. It's actually nice to have this PR
out and have the required lgtms already though. 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3818?email_source=notifications&email_token=AACRATG3MUYMFJS7RWFRJSDP3OC25A5CNFSM4HZNF2J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFOWQQ#issuecomment-504032066>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACRATBI6HYYIMROG57CIZ3P3OC25ANCNFSM4HZNF2JQ>
.
|
@neolit123 thank you for the clarification |
Evidently this is the wrong place to make a PR. What I want is a new project owned by the Cluster API group which is part of sig cluster lifecycle -- I'll close this and open a PR in kubernetes/org and update Cluster API's owners files and use those. |
/reopen @chuckha can you update this to just the cluster-api-provider-docker repo? |
@nikhita: Failed to re-open PR: state cannot be changed. The scl branch has been deleted. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Oh lol, let's move to another PR then. |
Signed-off-by: Chuck Ha chuckh@vmware.com
Adding two new subprojects. I will need the repos created before I can link to the owner files, unless I'm going about this the wrong way?
cc @detiber
edit: after this I can make an issue to make a repo that references this change