Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and rewording on one on one mentoring #4747

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Cleanup and rewording on one on one mentoring #4747

merged 1 commit into from
Apr 26, 2020

Conversation

markjacksonfishing
Copy link
Contributor

@markjacksonfishing markjacksonfishing commented Apr 25, 2020 •
edited by nikhita
Loading

Which issue(s) this PR fixes:

For #2657 Some cleanup and slight rewording

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2020
@k8s-ci-robot k8s-ci-robot added area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Apr 25, 2020
@markjacksonfishing
Updating 1:1 mentoring page
a655d19 
Signed-off-by: markyjackson-taulia <marky.r.jackson@gmail.com>
@markjacksonfishing
Copy link
Contributor Author

/assign @nikhita @idvoretskyi

@nikhita
Copy link
Member

nikhita commented Apr 26, 2020

Thanks, Marky!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markyjackson-taulia, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6689de9 into kubernetes:master Apr 26, 2020
@mrbobbytables mrbobbytables added this to the v1.19 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita Awaiting requested review from nikhita

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@idvoretskyi idvoretskyi

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@markjacksonfishing @nikhita @k8s-ci-robot @idvoretskyi @mrbobbytables