Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed all instances of k-dev@ and kubernetes-dev@ to dev@kubernetes.io #6311

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

chetak123
Copy link
Member

Which issue(s) this PR fixes:

Fixes #6275

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 27, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @chetak123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/community-management area/contributor-comms Issues or PRs related to the upstream marketing team area/contributor-guide Issues or PRs related to the contributor guide area/developer-guide Issues or PRs related to the developer guide area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. labels Dec 27, 2021
@k8s-ci-robot k8s-ci-robot added committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 27, 2021
@chetak123 chetak123 changed the title Changed all instancesof k-dev@ and kubernetes-dev@ to dev@kubernetes.io Changed all instances of k-dev@ and kubernetes-dev@ to dev@kubernetes.io Dec 27, 2021
@parispittman
Copy link
Contributor

/assign
/hold

thank you so much!! I'll review asap but it will take me a bit. will try and have a review done by this Thursday.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2021
Copy link
Member

@Debanitrkl Debanitrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the changes looks good to me
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 28, 2021
@cblecker
Copy link
Member

Please review #6311 (comment) and remove any changes to documents in these paths. Please also remove changes to documents in the archive/ folder. Thanks!

@@ -263,7 +263,7 @@ before being able to contribute effectively.
[Kubernetes GitHub Admin team]: /github-management/README.md#github-administration-team
[Kubernetes GitHub organizations]: /github-management#actively-used-github-organizations
[Kubernetes org]: https://github.com/kubernetes
[kubernetes-dev@googlegroups.com]: https://groups.google.com/forum/#!forum/kubernetes-dev
[dev@kubernetes.io]: https://groups.google.com/forum/#!forum/kubernetes-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link needs to be changed to the new destination

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cblecker it would really helpful if you can please provide link for new forum destination as I am not able to find it for dev@kubernetes.io

@@ -1293,7 +1293,7 @@
* @maciekpytel for "providing clarity" around the node autoscaler
* We're going to disable the cherrypick-auto-approve munger [aaron]
* Process now is based on cherrypick-approve
* [kubernetes-dev@ thread](https://groups.google.com/d/msg/kubernetes-dev/Br2-4pQPOIs/YbSM1YNIBgAJ)
* [dev@kubernetes.io thread](https://groups.google.com/d/msg/kubernetes-dev/Br2-4pQPOIs/YbSM1YNIBgAJ)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to change historical documents

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Dec 28, 2021
@@ -263,7 +263,7 @@ before being able to contribute effectively.
[Kubernetes GitHub Admin team]: /github-management/README.md#github-administration-team
[Kubernetes GitHub organizations]: /github-management#actively-used-github-organizations
[Kubernetes org]: https://github.com/kubernetes
[kubernetes-dev@googlegroups.com]: https://groups.google.com/forum/#!forum/kubernetes-dev
[dev@kubernetes.io]: https://groups.google.com/forum/#!forum/kubernetes-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[dev@kubernetes.io]: https://groups.google.com/forum/#!forum/kubernetes-dev
[dev@kubernetes.io]: https://groups.google.com/a/kubernetes.io/group/dev

@parispittman
Copy link
Contributor

Thank you @chetak123 for your work on this! I left the appropriate link; once that is updated, I'll release the hold and we can merge. :)

Copy link
Contributor

@parispittman parispittman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about that - missed 5 files that should not be changed as they are archives / should be kept for historical reasons. after that, we are really ready to merge :)

* Adding milestone is the only thing missing, right? [dankohn]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file does not need to be changed as its an archive so we should keep the history

@@ -2824,7 +2824,7 @@ Agenda:
* [Sig-testing’s deploy policy](https://github.com/kubernetes/community/blob/master/sig-testing/charter.md#deploying-changes)
* [Sig-contribex’s deploy policy](https://github.com/kubernetes/community/blob/master/sig-contributor-experience/charter.md#cross-cutting-and-externally-facing-processes)
* Dec 10 not sure if this is the root cause PR? [https://github.com/kubernetes/test-infra/pull/10435](https://github.com/kubernetes/test-infra/pull/10435)
* Dec 10 notify k-dev@ of k/community change [https://groups.google.com/forum/#!msg/kubernetes-dev/oWbV6uiQMIM/0ku8cvSZBgAJ](https://groups.google.com/forum/#!msg/kubernetes-dev/oWbV6uiQMIM/0ku8cvSZBgAJ)
* Dec 10 notify dev@kubernetes.io of k/community change [https://groups.google.com/forum/#!msg/kubernetes-dev/oWbV6uiQMIM/0ku8cvSZBgAJ](https://groups.google.com/forum/#!msg/kubernetes-dev/oWbV6uiQMIM/0ku8cvSZBgAJ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file does not need to be changed as its an archive so we should keep the history

@@ -13,7 +13,7 @@ placeholder - will be updated in another PR
| Format in this folder | .csv |
| File Name | /contribex-survey-2019.csv //another PR |
| Drive URL Link | tbu |
| Announced | kubernetes-dev@googlegroups.com, various sig-meetings, community meetings, kubernetes-dev slack channel, chairs-and-techleads channels, and @kubernetesio twitter |
| Announced | dev@kubernetes.io, various sig-meetings, community meetings, kubernetes-dev slack channel, chairs-and-techleads channels, and @kubernetesio twitter |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file does not need to be changed as its an archive so we should keep the history (same with the other survey csv file that you have hooked)

@@ -25,7 +25,7 @@
'Most_Important_Proj:_GH_Mgmt':'Most_Important_Proj:_GitHub_Management',
'Most_Important_Proj:_Contributor_Summits':'Most_Important_Proj:_Delivering_valuable_contributor_summits_at_relevant_events',
'Most_Important_Proj:_Keeping_community_safe': 'Most_Important_Proj:_Keeping_our_community_safe_on_our_various_communication_platforms_through_moderation_guidelines_and_new_approaches',
'Check_for_news:_k-dev_ML':'Check_for_news:_kubernetes-dev@_mailing_list',
'Check_for_news:_k-dev_ML':'Check_for_news:_dev@kubernetes.io_mailing_list',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file does not need to be changed as its an archive so we should keep the history

@@ -8,7 +8,7 @@ Owners: @kubernetes/docs, @kubernetes/examples

Labels: [kind/documentation](https://github.com/kubernetes/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Akind%2Fdocumentation), [kind/example](https://github.com/kubernetes/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Akind%2Fexample)

We're currently planning a documentation site overhaul. Join kubernetes-dev@googlegroups.com to gain access to the proposals.
We're currently planning a documentation site overhaul. Join dev@kubernetes.io to gain access to the proposals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file does not need to be changed as its an archive so we should keep the history

@cblecker cblecker added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 3, 2022
@@ -47,7 +47,7 @@ make test-e2e-node PRINT_HELP=y
Why run tests *remotely*? Tests will be run in a customized testing environment. This environment closely mimics the pre- and post- submit testing performed by the project.

Prerequisites:
- [Join the googlegroup](https://groups.google.com/forum/#!forum/kubernetes-dev) `kubernetes-dev@googlegroups.com`
- [Join the googlegroup](https://groups.google.com/forum/#!forum/kubernetes-dev) `dev@kubernetes.io`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link needs to change to the new forum

@chetak123 chetak123 force-pushed the ML_Migration branch 2 times, most recently from dafd37c to c330741 Compare January 4, 2022 03:03
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2022
Changes Removed From archive

updated the link

changes made

csv undo

changed links
@parispittman
Copy link
Contributor

thanks so much for sticking through this!
/hold cancel
/lgtm

will wait for Christoph or another approver

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 4, 2022
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple ones, but as we want to get this in, I'm just gonna commit these and merge.

Thanks @chetak123 !

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, these two as well are from elections that have already happened

@cblecker
Copy link
Member

cblecker commented Jan 5, 2022

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, chetak123, Debanitrkl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 737df3c into kubernetes:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/contributor-comms Issues or PRs related to the upstream marketing team area/contributor-guide Issues or PRs related to the contributor guide area/developer-guide Issues or PRs related to the developer guide area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML Migration] Post migration: kdev mailing list
5 participants