-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the CRI documentation for 1.7 #743
Conversation
|
||
## Work-In-Progress CRI runtimes | ||
|
||
- [cri-o](https://github.com/kubernetes-incubator/cri-o) | ||
- [rktlet](https://github.com/kubernetes-incubator/rktlet) | ||
- [frakti](https://github.com/kubernetes/frakti) | ||
- [cri-containerd](https://github.com/kubernetes-incubator/cri-containerd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank!
|
||
- [Original proposal](https://github.com/kubernetes/kubernetes/blob/release-1.5/docs/proposals/container-runtime-interface-v1.md) | ||
- [Networking](https://github.com/kubernetes/community/blob/master/contributors/devel/kubelet-cri-networking.md) | ||
- [Container metrics](https://github.com/kubernetes/community/blob/master/contributors/devel/cri-container-stats.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Deadlink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's being added in another PR #742
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
each release. Note that CRI API is still in its early stages. We are actively | ||
incorporating feedback from early developers to improve the API. Developers | ||
should expect occasional API breaking changes. | ||
CRI is still young and we are actively incorporating feedback from developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double spaces before "developers"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
## [Status update](#status-update) | ||
### Kubernetes v1.7 release (Docker-CRI integration GA, container metrics API) | ||
- The Docker CRI integration has been promoted to GA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to mention --enable-cri
flag is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Addressed the comments. |
LGTM |
/lgtm |
Approved on 4/11 by TOC
No description provided.