-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Marketing Request Template #7900
Rework Marketing Request Template #7900
Conversation
Skipping CI for Draft Pull Request. |
/assign @kaslin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting a few grammar and typo fixes 👍🏻
Please change the filename, please (you might need to change something else too if the filename is used elsewhere). comms-request.yaml is fine. We need to lose the word Marketing |
Regarding the selection of the communication channel, I fear that people might be overwhelmed with the choice of the options. My suggestion is that this falls with the responsibility of sig-contribex-comms as we might know better. |
Co-authored-by: Arvind <aruparekh@gmail.com>
Co-authored-by: Arvind <aruparekh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed. Lgtm 👍🏻
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaslin, mfahlandt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As the comms team have now communications channels with different audience, comms requests need to include the target audience.
Based on this, Comms can choose what are the fitting communication channels.
We also added the Option if writing drafts is needed.