Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Marketing Request Template #7900

Merged

Conversation

mfahlandt
Copy link
Contributor

As the comms team have now communications channels with different audience, comms requests need to include the target audience.
Based on this, Comms can choose what are the fitting communication channels.
We also added the Option if writing drafts is needed.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
@mfahlandt
Copy link
Contributor Author

/assign @kaslin
/assign @chris-short

Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a few grammar and typo fixes 👍🏻

.github/ISSUE_TEMPLATE/marketing-request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/marketing-request.yml Outdated Show resolved Hide resolved
@chris-short
Copy link
Contributor

Please change the filename, please (you might need to change something else too if the filename is used elsewhere). comms-request.yaml is fine. We need to lose the word Marketing

@mfahlandt
Copy link
Contributor Author

Regarding the selection of the communication channel, I fear that people might be overwhelmed with the choice of the options. My suggestion is that this falls with the responsibility of sig-contribex-comms as we might know better.
@chris-short

@mfahlandt mfahlandt marked this pull request as ready for review August 9, 2024 11:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Lgtm 👍🏻

@chris-short
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@kaslin
Copy link
Contributor

kaslin commented Sep 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaslin, mfahlandt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit c83a1eb into kubernetes:master Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants