-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mysterious local etcd path documentation #7916
Conversation
Welcome @seantywork! |
Hi @seantywork. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: seantywork The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -345,10 +345,13 @@ To test Kubernetes, you will need to install a recent version of [etcd](https:// | |||
This script will instruct you to make a change to your `PATH`. To make | |||
this permanent, add this to your `.bashrc` or login script: | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks,
to be clear, is this just deleting a blank line or related to fmt rule?
at contributors/devel/development.md,
in section regarding local etcd installatioin using hack/install-etcd.sh,
above line exists.
The problem is that the local etcd installation path is actually
So I modified that part and added explanation
Which issue(s) this PR fixes:
Fixes #