Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hydrophone announcement #502

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented May 15, 2024

Hydrophobe is a SIG Testing project that has recently been started and is now ready to be shared with a wider audience of contributors.

/cc @rjsadow @chris-short

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
@rjsadow
Copy link
Contributor

rjsadow commented May 15, 2024

/retitle Add Hydrophobe announcement
/lgtm
Thanks @fsmunoz! 🎉

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Add Hydrophobe announcement Add Hydrophobe announcement May 15, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 15, 2024
@sftim
Copy link
Contributor

sftim commented May 15, 2024

Hydrophone, right? (A hydrophobe is either a person who fears water, or more commonly a patient with rabies).

/retitle Add Hydrophone announcement

@k8s-ci-robot k8s-ci-robot changed the title Add Hydrophobe announcement Add Hydrophone announcement May 15, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Is there a logo (no worries if not)?

content/en/blog/2024/introducing-hydrophone.md Outdated Show resolved Hide resolved
content/en/blog/2024/introducing-hydrophone.md Outdated Show resolved Hide resolved
content/en/blog/2024/introducing-hydrophone.md Outdated Show resolved Hide resolved
content/en/blog/2024/introducing-hydrophone.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented May 15, 2024

/approve
/hold

@fsmunoz you are welcome to unhold this; if you want to incorporate feedback from the recent review, that's fine too.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2024
@rjsadow
Copy link
Contributor

rjsadow commented May 15, 2024

Thanks @sftim! I like all of the proposed changes.

@sftim
Copy link
Contributor

sftim commented May 16, 2024

You can use GitHub to accept those suggestions and commit them, @fsmunoz (cc: @rjsadow).

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Ricky Sadowski <richard.j.sadowski@gmail.com>
@fsmunoz
Copy link
Contributor Author

fsmunoz commented May 16, 2024

Thank you @sftim (and it was indeed Hydrophone, not sure were my mind was going when it went with Hydrophobe in the title). I've added them and squashed.

@chris-short
Copy link
Contributor

You got me. I was Googling whatever word you used to make sure I wasn't losing my mind.

@rjsadow
Copy link
Contributor

rjsadow commented May 16, 2024

Great! Is there a logo (no worries if not)?

We don't currently have a logo. We're open to ideas though :) There have been a few floated around previously.

@rjsadow
Copy link
Contributor

rjsadow commented May 16, 2024

/lgtm
@fsmunoz feel free to unhold when you're ready to release.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@sftim
Copy link
Contributor

sftim commented May 16, 2024

This won't publish until 2023-05-23, even if merged earlier

Co-authored-by: Arvind <aruparekh@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 20, 2024
@jberkus
Copy link
Contributor

jberkus commented May 20, 2024

Lemme replace that
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@sftim
Copy link
Contributor

sftim commented May 21, 2024

I'm assuming we're not mirroring this to https://blog.k8s.io/ - have I got that right?

@sftim
Copy link
Contributor

sftim commented May 21, 2024

/approve
/hold

OK to unhold if [this article isn't to be mirrored and it's on or before the 23rd of May 2024]

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rjsadow
Copy link
Contributor

rjsadow commented May 21, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 41fdf63 into kubernetes:master May 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

7 participants