Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/implementation support request: cluster graph integration #2008

Open
ghost opened this issue Jun 2, 2017 · 12 comments
Open

Feature/implementation support request: cluster graph integration #2008

ghost opened this issue Jun 2, 2017 · 12 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ghost
Copy link

ghost commented Jun 2, 2017

I deploy K8s/dashboard via kops, and I would like to integrate kubernetes-ui/graph into the dashboard. It would show up on the condition that cluster-insight is running.

Is there currently a plugin/component system for dashboard? Could someone who has architectural overview of dashboard help me make a rough outline of the work that has to be done to integrate the cluster graph into dashboard?

@bryk bryk self-assigned this Jun 2, 2017
@bryk
Copy link
Contributor

bryk commented Jun 2, 2017

There's no extension mechanism at the moment. So this is all do-it-yourself. I think, though, this is the right moment to start thinking about the extensions framework for UI for real.

@bryk
Copy link
Contributor

bryk commented Jun 2, 2017

@floreks @maciaszczykm @cheld WDYT of doing this via one-off compile time hardcoding versus extensions framework?

@cheld
Copy link
Contributor

cheld commented Jun 2, 2017

The scope plugin uses an Iframe. #1949

The helm plugin we are thinking to integrate directly. Not sure about the best approach

In addition @floreks is thinking about a global settings page, backed by a config map to enable/disable plugins - like in chrome

@bryk
Copy link
Contributor

bryk commented Jun 2, 2017

Yeah. So there's a lot of these things appearing recently. I expect to see more. We could tackle this problem in a generic way to help everyone in one sweep. This is a large project, though.

@floreks
Copy link
Member

floreks commented Jun 5, 2017

It would be nice to have some extensions framework, but there are many things to consider. We need to discuss that first and think how to provide such a mechanism in a generic and dynamic way that will not require direct dashboard changes.

What I'm working on is not a plugin mechanism but integrations framework for our backend. This means that still we will need to introduce all integrations related code upstream. It will be just easier to integrate with dashboard.

@floreks floreks added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 5, 2017
@bryk
Copy link
Contributor

bryk commented Jun 5, 2017

Do you have any designs for the integrations framework already? Can we talk about this? :)

@floreks
Copy link
Member

floreks commented Jun 5, 2017

It's still an early sketch. I've been preparing other parts of backend for such framework. I want to minimize work needed to introduce new integrations later on so API still changes. Also I need to introduce some kind of storage provider with storage sync that will keep config up to date and integrate that with integrations manager.

There are many things to consider so I'm trying not to rush anything. It would be nice to discuss it. We can do that tomorrow.

@ghost
Copy link
Author

ghost commented Jun 12, 2017

Hi, just checking in on the extension framework/cluster graph integration, is there anything I could do to help further this integration?

@floreks, could you perhaps write a roadmap of what you think the issues to discuss are before implementing a extension framework?

@floreks
Copy link
Member

floreks commented Jun 12, 2017

First part can be seen in #2017 pull request. I still need to clean up some code but overall structure is already there. Right now I don't have clear roadmap. For sure after this part I will be working on some storage sync to be able to save per user config.

Unfortunately right now I don't see any tasks that could be done in parallel. Base part has to finished first and then new integrations i.e. prometheus for metrics can be added.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 26, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@floreks floreks reopened this Feb 25, 2018
@maciaszczykm maciaszczykm added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 27, 2018
@maciaszczykm maciaszczykm removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants