Feature scope #1949

vlal-zz · 2017-05-15T10:36:25Z

Add scope to k8s dashboard

olekzabl · 2017-05-17T07:16:26Z

src/app/backend/resource/scope/scope.go

+	Address  string `json:"address"`
+}
+
+// GetScope returns a populated Scope struct.


Copy-pasted comment?

olekzabl · 2017-05-17T07:21:35Z

src/app/frontend/scope/controller.js

+   * @export
+   */
+  pingScope(tries) {
+    if (tries < 5) {


Calling pingScope(5) will do nothing, right? I initially was a little confused by this.
Can you refactor this argument (e.g. to decrease until 0), or add a comment about its meaning?

codecov · 2017-05-18T09:34:11Z

Codecov Report

Merging #1949 into master will decrease coverage by 0.37%.
The diff coverage is 29.74%.

@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
- Coverage   59.08%   58.71%   -0.38%     
==========================================
  Files         582      587       +5     
  Lines       12171    12328     +157     
==========================================
+ Hits         7191     7238      +47     
- Misses       4811     4919     +108     
- Partials      169      171       +2

Impacted Files	Coverage Δ
src/app/frontend/scope/state.js	`100% <100%> (ø)`
src/app/frontend/chrome/nav/nav_component.js	`93.33% <100%> (+0.22%)`	⬆️
src/app/frontend/index_module.js	`100% <100%> (ø)`	⬆️
src/app/frontend/scope/controller.js	`2.12% <2.12%> (ø)`
src/app/backend/handler/apihandler.go	`26.28% <21.95%> (-0.09%)`	⬇️
src/app/backend/resource/scope/scope.go	`41.5% <41.5%> (ø)`
src/app/frontend/scope/module.js	`75% <75%> (ø)`
src/app/frontend/scope/stateconfig.js	`88.88% <88.88%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53876ed...bcb5ea5. Read the comment docs.

bryk · 2017-06-02T19:56:27Z

src/app/backend/resource/scope/scope.go

+func PostScope(client client.Interface) (*Scope, error) {
+	log.Print("Installing scope on the cluster")
+
+	response, err := http.Get("https://cloud.weave.works/launch/k8s/weavescope.yaml?k8s-service-type=NodePort")


This is the part I'm worried about. It allows cloud.weave.works to hack user's cluster. Can we embed the YAML in repository here and versionize it? It'd be a bit safer at least.

@bryk I believe that's been resolved now. Could you please review the rest of this PR and let @vlal and myself know if you broadly approve of it before we rebase and update? Thanks!

fejta-bot · 2018-01-04T02:36:37Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

errordeveloper · 2018-01-20T14:51:41Z

Let's get back to this!

/remove-lifecycle stale

cc @danielromlein @bryk

maciaszczykm · 2018-01-20T15:51:49Z

@errordeveloper I think it is not the best time. We are migrating the whole app to new Angular and it would be better to wait for it. Let's wait for #2727 and return to this discussion then.

errordeveloper · 2018-01-20T18:22:42Z

Thanks, Marcin! We shall wait.

…

On Sat, 20 Jan 2018, 3:51 pm Marcin Maciaszczyk, ***@***.***> wrote: @errordeveloper <https://github.com/errordeveloper> I think it is not the best time. We are migrating the whole app to new Angular and there is no sense in implementing it for AngularJS. Let's wait for #2727 <#2727> and return to this discussion then. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1949 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPWS5gfs2FqmHselsm1-UtkZWn5jACrks5tMguZgaJpZM4Na9E4> .

fejta-bot · 2018-04-20T19:18:53Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2018-05-20T20:06:10Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

fejta-bot · 2018-06-19T20:52:58Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2017

vlal-zz closed this May 15, 2017

vlal-zz reopened this May 15, 2017

lukemarsden mentioned this pull request May 16, 2017

Proposal: experimentally embed Weave Scope #1577

Closed

olekzabl reviewed May 17, 2017

View reviewed changes

vlal-zz force-pushed the feature-scope branch from c600b2d to a3e5e1e Compare May 18, 2017 09:23

vlal-zz force-pushed the feature-scope branch 2 times, most recently from 15d1bfb to 89d40e2 Compare May 18, 2017 10:15

cheld mentioned this pull request Jun 2, 2017

Feature/implementation support request: cluster graph integration #2008

Open

bryk suggested changes Jun 2, 2017

View reviewed changes

vlal-zz force-pushed the feature-scope branch from fba1141 to 2c2836b Compare June 12, 2017 14:39

cheld mentioned this pull request Jun 30, 2017

kube-addon-update revamp kubernetes/kubernetes#23233

Closed

Vishal Lal added 2 commits August 14, 2017 11:55

Add Scope to Kubernetes Dashboard

5a8a186

Add versioned scope.yaml, ref to github

9583aeb

vlal-zz force-pushed the feature-scope branch from 2c2836b to 9583aeb Compare August 14, 2017 18:55

Fixes since last rebased

bcb5ea5

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2018

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2018

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2018

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 20, 2018

k8s-ci-robot closed this Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature scope #1949

Feature scope #1949

vlal-zz commented May 15, 2017

olekzabl May 17, 2017

olekzabl May 17, 2017

codecov bot commented May 18, 2017 •

edited

Loading

bryk Jun 2, 2017

errordeveloper Aug 30, 2017

fejta-bot commented Jan 4, 2018

errordeveloper commented Jan 20, 2018

maciaszczykm commented Jan 20, 2018 •

edited

Loading

errordeveloper commented Jan 20, 2018 via email

fejta-bot commented Apr 20, 2018

fejta-bot commented May 20, 2018

fejta-bot commented Jun 19, 2018

Feature scope #1949

Feature scope #1949

Conversation

vlal-zz commented May 15, 2017

olekzabl May 17, 2017

Choose a reason for hiding this comment

olekzabl May 17, 2017

Choose a reason for hiding this comment

codecov bot commented May 18, 2017 • edited Loading

Codecov Report

bryk Jun 2, 2017

Choose a reason for hiding this comment

errordeveloper Aug 30, 2017

Choose a reason for hiding this comment

fejta-bot commented Jan 4, 2018

errordeveloper commented Jan 20, 2018

maciaszczykm commented Jan 20, 2018 • edited Loading

errordeveloper commented Jan 20, 2018 via email

fejta-bot commented Apr 20, 2018

fejta-bot commented May 20, 2018

fejta-bot commented Jun 19, 2018

codecov bot commented May 18, 2017 •

edited

Loading

maciaszczykm commented Jan 20, 2018 •

edited

Loading