Dashboard "exec" should run cmd.exe on Windows pods instead of bash

[feiskyer]

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

How to reproduce it (as minimally and precisely as possible):

1. Deploy a Kubernetes cluster with Windows nodes
2. Deploy any Windows pod
3. Go to Kubernetes dashboard, find the pod, and click "exec" at the top

What happened:

This tried to launch bash which isn't on Windows by default.

container dd24fce994bbab4b0376b723e76f1257129492a8829d404d5913cd707bab3868 encountered an error during CreateProcess: failure in a Windows system call: The system cannot find the file specified. (0x2) extra info: {"ApplicationName":"","CommandLine":"bash","User":"","WorkingDirectory":"C:\\","Environment":{"IIS_PORT":"tcp://10.0.132.120:80","IIS_PORT_80_TCP":"tcp://10.0.132.120:80","IIS_PORT_80_TCP_ADDR":"10.0.132.120","IIS_PORT_80_TCP_PORT":"80","IIS_PORT_80_TCP_PROTO":"tcp","IIS_SERVICE_HOST":"10.0.132.120","IIS_SERVICE_PORT":"80","IIS_SERVICE_PORT_TCP_80_80_VSRHX":"80","KUBERNETES_PORT":"tcp://10.0.0.1:443","KUBERNETES_PORT_443_TCP":"tcp://10.0.0.1:443","KUBERNETES_PORT_443_TCP_ADDR":"10.0.0.1","KUBERNETES_PORT_443_TCP_PORT":"443","KUBERNETES_PORT_443_TCP_PROTO":"tcp","KUBERNETES_SERVICE_HOST":"10.0.0.1","KUBERNETES_SERVICE_PORT":"443","KUBERNETES_SERVICE_PORT_HTTPS":"443"},"EmulateConsole":true,"CreateStdInPipe":true,"CreateStdOutPipe":true,"CreateStdErrPipe":false,"ConsoleSize":[0,0]}
container dd24fce994bbab4b0376b723e76f1257129492a8829d404d5913cd707bab3868 encountered an error during CreateProcess: failure in a Windows system call: The system cannot find the file specified. (0x2) extra info: {"ApplicationName":"","CommandLine":"sh","User":"","WorkingDirectory":"C:\\","Environment":{"IIS_PORT":"tcp://10.0.132.120:80","IIS_PORT_80_TCP":"tcp://10.0.132.120:80","IIS_PORT_80_TCP_ADDR":"10.0.132.120","IIS_PORT_80_TCP_PORT":"80","IIS_PORT_80_TCP_PROTO":"tcp","IIS_SERVICE_HOST":"10.0.132.120","IIS_SERVICE_PORT":"80","IIS_SERVICE_PORT_TCP_80_80_VSRHX":"80","KUBERNETES_PORT":"tcp://10.0.0.1:443","KUBERNETES_PORT_443_TCP":"tcp://10.0.0.1:443","KUBERNETES_PORT_443_TCP_ADDR":"10.0.0.1","KUBERNETES_PORT_443_TCP_PORT":"443","KUBERNETES_PORT_443_TCP_PROTO":"tcp","KUBERNETES_SERVICE_HOST":"10.0.0.1","KUBERNETES_SERVICE_PORT":"443","KUBERNETES_SERVICE_PORT_HTTPS":"443"},"EmulateConsole":true,"CreateStdInPipe":true,"CreateStdOutPipe":true,"CreateStdErrPipe":false,"ConsoleSize":[0,0]}

What you expected to happen:

On Windows, it should default to running cmd.exe instead. Probably add cmd.exe here https://github.com/kubernetes/dashboard/blob/master/src/app/backend/handler/terminal.go#L257

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version): 1.9.3
• Cloud provider or hardware configuration: Azure steps
• OS (e.g. from /etc/os-release): Windows Server, version 1709

Labels
/sig windows

[feiskyer]

/cc @PatrickLang

[floreks]

Closing in favor of #2029. All enhancements are tracked from there.

[PatrickLang]

So will there be multiple PRs tracked against #2029, or is there one big PR that someone is already working on?

[floreks]

There should be multiple PRs related to #2029. I don't think that anyone is working on it currently.

[feiskyer]

Filed a PR #2922 to fix this