Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exec support for windows containers #2922

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

feiskyer
Copy link
Member

Fix #2888

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2018
@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #2922 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2922      +/-   ##
==========================================
- Coverage   54.17%   54.16%   -0.01%     
==========================================
  Files         564      564              
  Lines       12199    12199              
==========================================
- Hits         6609     6608       -1     
- Misses       5334     5335       +1     
  Partials      256      256
Impacted Files Coverage Δ
src/app/backend/handler/terminal.go 0% <0%> (ø) ⬆️
...p/backend/integration/metric/common/aggregation.go 87.69% <0%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3988cad...3e7c589. Read the comment docs.

@michmike
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2018
@bsteciuk
Copy link

Only suggestion might be to add ash as well, would resolve #2305

@feiskyer
Copy link
Member Author

@floreks PTAL

@bryk bryk added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2018
@bryk
Copy link
Contributor

bryk commented Apr 24, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryk, feiskyer, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants