Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update breadcrumbs to show last 3 states for entire app #1471

Merged
merged 4 commits into from
Nov 24, 2016
Merged

Update breadcrumbs to show last 3 states for entire app #1471

merged 4 commits into from
Nov 24, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Nov 23, 2016

Re #1268

Demo:
image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2016
@bryk
Copy link
Contributor Author

bryk commented Nov 23, 2016

@floreks Can you review this?

@bryk bryk changed the title Update breadcrumbs to show ast 3 states for entire app Update breadcrumbs to show last 3 states for entire app Nov 23, 2016
@codecov-io
Copy link

Current coverage is 93.41% (diff: 87.87%)

Merging #1471 into master will decrease coverage by 0.08%

@@             master      #1471   diff @@
==========================================
  Files           368        368          
  Lines          3046       3067    +21   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2848       2865    +17   
- Misses          198        202     +4   
  Partials          0          0

Powered by Codecov. Last update c790fb8...74abbe2

@floreks
Copy link
Member

floreks commented Nov 23, 2016

Code LGTM, however I am not able to test it today. @maciaszczykm could you test and confirm everything works as expected?

floreks
floreks approved these changes Nov 23, 2016
View reviewed changes
Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciaszczykm
Copy link
Member

I'll test now.

maciaszczykm
maciaszczykm approved these changes Nov 24, 2016
View reviewed changes
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Persistent Volume Claims aren't listed under Storage, but Storage remains to be implemented.

@maciaszczykm maciaszczykm merged commit 3c30276 into kubernetes:master Nov 24, 2016
@bryk
Copy link
Contributor Author

bryk commented Nov 25, 2016

Persistent Volume Claims aren't listed under Storage, but Storage remains to be implemented.

Yes, correct.

@bryk bryk deleted the breadcrumbs branch November 25, 2016 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@floreks floreks floreks approved these changes

Assignees

@floreks floreks

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bryk @codecov-io @floreks @maciaszczykm @k8s-ci-robot