Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file-exists to the latest version 🚀 #2413

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Sep 27, 2017

Version 5.0.0 of file-exists just got published.

Dependency file-exists
Current Version 4.0.0
Type devDependency

The version 5.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of file-exists.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 5 commits.

  • bc52f38 Release 5.0.0
  • 366b6ab Merge pull request #10 from RobLoach/promise
  • 38df71a Add Promise documentation to README.md
  • e8ddb7f Fix Promise error reporting
  • e1be664 Add Promise support

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2017
@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #2413 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2413      +/-   ##
=========================================
+ Coverage   58.67%   58.7%   +0.03%     
=========================================
  Files         596     596              
  Lines       12843   12843              
=========================================
+ Hits         7535    7539       +4     
+ Misses       5116    5111       -5     
- Partials      192     193       +1
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.23% <0%> (+1.53%) ⬆️
src/app/backend/sync/secret.go 71.79% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc09af2...d7c89fc. Read the comment docs.

@floreks floreks merged commit 3512d5b into master Sep 28, 2017
@floreks floreks deleted the greenkeeper/file-exists-5.0.0 branch September 28, 2017 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants