Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dashboard crash after exec into pod when using proxy #2430

Merged
merged 2 commits into from
Oct 2, 2017

Conversation

floreks
Copy link
Member

@floreks floreks commented Oct 2, 2017

Related to #2029

Dashboard was crashing when trying to exec into pod. This was caused by missing tmp directory in the dashboard container. I have added /tmp mount that will be stored in memory on disk.

Tested on k8s 1.7.7. Exec works fine when accessing Dashboard using NodePort and kubectl proxy.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2017
@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #2430 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2430   +/-   ##
=======================================
  Coverage   58.82%   58.82%           
=======================================
  Files         596      596           
  Lines       12896    12896           
=======================================
  Hits         7586     7586           
  Misses       5116     5116           
  Partials      194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b8874...ff69951. Read the comment docs.

Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to keeping it on disk rather than in memory.

@floreks floreks merged commit 40ca85e into kubernetes:master Oct 2, 2017
@floreks floreks deleted the fix-exec-crash branch October 2, 2017 11:22
@adrianchifor
Copy link

adrianchifor commented Oct 4, 2017

@floreks How can we view exec logs in the /tmp dir if we can't exec into the dashboard pod (no sh or bash) ? Can we maybe get an alpine based docker image?

@floreks
Copy link
Member Author

floreks commented Oct 4, 2017

It is only required to make exec feature work in dashboard. These files are created when you exec into pod (any pod) and deleted when exec session is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants