Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build to use Minikube 1.8.0 #2514

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Update build to use Minikube 1.8.0 #2514

merged 1 commit into from
Oct 24, 2017

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Oct 24, 2017 •
edited
Loading

@maciaszczykm maciaszczykm self-assigned this Oct 24, 2017
@maciaszczykm maciaszczykm requested a review from cheld October 24, 2017 09:10
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2017
@maciaszczykm maciaszczykm added this to the 1.8 milestone Oct 24, 2017
@codecov
Copy link

codecov bot commented Oct 24, 2017 •
edited
Loading

Codecov Report

Merging #2514 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2514      +/-   ##
==========================================
- Coverage   59.08%   59.05%   -0.03%     
==========================================
  Files         580      580              
  Lines       12659    12659              
==========================================
- Hits         7479     7476       -3     
- Misses       4985     4989       +4     
+ Partials      195      194       -1
Impacted Files Coverage Δ
src/app/backend/sync/secret.go 66.94% <0%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b715cf...d20d945. Read the comment docs.

@maciaszczykm
Copy link
Member Author

@cheld Please take a look.

@cheld cheld changed the title Update minikube to use Kubernetes 1.8.0 Update build to use Minikube 1.8.0 Oct 24, 2017
cheld
cheld approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@cheld cheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciaszczykm maciaszczykm merged commit ebc30e3 into kubernetes:master Oct 24, 2017
@maciaszczykm maciaszczykm deleted the minikube-ver branch October 24, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheld cheld cheld approved these changes

Assignees

@maciaszczykm maciaszczykm

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciaszczykm @cheld @k8s-ci-robot