-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide nodePort in internal endpoints when nodePort is not set #2858
Conversation
/assign @bryk |
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
=======================================
Coverage 54.17% 54.17%
=======================================
Files 564 564
Lines 12199 12199
=======================================
Hits 6609 6609
Misses 5334 5334
Partials 256 256 Continue to review full report at Codecov.
|
any update? @bryk |
@bryk Any update? |
/lgtm /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryk, jqlu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to show nodePort in dashboad? |
What this PR does
When nodePort is not set for a service, hide the nodePort endpoint rather than display a :0 endpoint.
How to reproduce it
How to fix it
Add a ng-if directive for Internal endpoints fields