Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide nodePort in internal endpoints when nodePort is not set #2858

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

jqlu
Copy link
Contributor

@jqlu jqlu commented Feb 24, 2018

What this PR does

When nodePort is not set for a service, hide the nodePort endpoint rather than display a :0 endpoint.

How to reproduce it

  1. deploy a ClusterIP type service
apiVersion: v1
kind: Service
metadata:
  name: my-service1
  labels:
    app: nginx-svc
spec:
  selector:
    app: nginx
  ports:
  - protocol: TCP
    name: http
    port: 30080
    targetPort: 80
  type: ClusterIP
  1. open Dashboard - Service list
  2. check Internal endpoints column of the service above
my-service1:30080 TCP
my-service1:0 TCP

How to fix it

Add a ng-if directive for Internal endpoints fields

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2018
@jqlu
Copy link
Contributor Author

jqlu commented Feb 24, 2018

/assign @bryk

@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #2858 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2858   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files         564      564           
  Lines       12199    12199           
=======================================
  Hits         6609     6609           
  Misses       5334     5334           
  Partials      256      256

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0274d8...a0ee15f. Read the comment docs.

@jqlu
Copy link
Contributor Author

jqlu commented Apr 11, 2018

any update? @bryk

@denverdino
Copy link
Contributor

@bryk Any update?

@bryk
Copy link
Contributor

bryk commented Apr 19, 2018

/lgtm /approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryk, jqlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2018
@bryk bryk added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit afd628b into kubernetes:master Apr 19, 2018
@salwell
Copy link

salwell commented Nov 5, 2018

How to show nodePort in dashboad?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants