Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Volume Mode #2909

Closed
wants to merge 1 commit into from
Closed

Secret Volume Mode #2909

wants to merge 1 commit into from

Conversation

djsd123
Copy link

@djsd123 djsd123 commented Mar 21, 2018

The pod will error when using the --auto-generate-certificates flag
while trying to write the cert file. This is because a secret's volume mode is set to 0400 by default. See
docs

The pod will error when using the `--auto-generate-certificates` flag
while trying to write the cert file. This is because a secret's volume mode is set to `0400` by default.  See
[docs](https://kubernetes.io/docs/concepts/configuration/secret/)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: djsd123
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rf232

Assign the PR to them by writing /assign @rf232 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djsd123
Copy link
Author

djsd123 commented Mar 21, 2018

/assign @rf232

@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #2909 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2909      +/-   ##
==========================================
- Coverage   54.17%   54.16%   -0.01%     
==========================================
  Files         564      564              
  Lines       12199    12199              
==========================================
- Hits         6609     6608       -1     
- Misses       5334     5335       +1     
  Partials      256      256
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 87.69% <0%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a1861...8560a5c. Read the comment docs.

@floreks
Copy link
Member

floreks commented Mar 21, 2018

Auto generate certs option behavior was changed to keep them in-memory in #2795 PR. Secret is only used as read-only in case user wants to override certificates with custom ones by creating/editing this secret.

@floreks
Copy link
Member

floreks commented Mar 26, 2018

I'm closing this as this change is not needed due to #2795.

@floreks floreks closed this Mar 26, 2018
@djsd123
Copy link
Author

djsd123 commented Mar 26, 2018

Fair enough @floreks. Wierd that the defaultMode was required when deploying master last week. Thanks anyway..

@floreks
Copy link
Member

floreks commented Mar 26, 2018

Possibly you were using Dashboard 1.8.2 instead of 1.8.3 or older version was taken from cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants