-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling the skip button #3077
Allow disabling the skip button #3077
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @floreks |
Seems like the integration tests have failed. Sorry, I only have a very basic understanding of Angular and JS. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #3077 +/- ##
==========================================
+ Coverage 54.19% 54.23% +0.03%
==========================================
Files 564 564
Lines 12194 12209 +15
==========================================
+ Hits 6609 6621 +12
- Misses 5329 5332 +3
Partials 256 256
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The continuous integration issue seems to be resolved. Thanks for the contribution!
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: onitake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR implements the feature requested in #2672 .
It is not fully tested yet, as the dashboard has considerable dependencies on the runtime environment, which are difficult to fulfil on my test system.
The backend part should work as expected, however.
I've split the PR into multiple commits for easier review.