Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the skip button #3077

Merged
merged 10 commits into from
Jun 11, 2018

Conversation

onitake
Copy link
Contributor

@onitake onitake commented Jun 4, 2018

This PR implements the feature requested in #2672 .

It is not fully tested yet, as the dashboard has considerable dependencies on the runtime environment, which are difficult to fulfil on my test system.
The backend part should work as expected, however.

I've split the PR into multiple commits for easier review.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2018
@onitake
Copy link
Contributor Author

onitake commented Jun 4, 2018

/assign @floreks
/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2018
@onitake
Copy link
Contributor Author

onitake commented Jun 4, 2018

Seems like the integration tests have failed.

Sorry, I only have a very basic understanding of Angular and JS.
Would be nice if someone more familiar with the frontend code could look into it.

Thanks!

@codecov
Copy link

codecov bot commented Jun 4, 2018

Codecov Report

Merging #3077 into master will increase coverage by 0.03%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3077      +/-   ##
==========================================
+ Coverage   54.19%   54.23%   +0.03%     
==========================================
  Files         564      564              
  Lines       12194    12209      +15     
==========================================
+ Hits         6609     6621      +12     
- Misses       5329     5332       +3     
  Partials      256      256
Impacted Files Coverage Δ
src/app/backend/auth/api/types.go 30.76% <ø> (ø) ⬆️
src/app/frontend/login/stateconfig.js 60% <0%> (-15%) ⬇️
src/app/backend/auth/manager.go 67.39% <100%> (+2.27%) ⬆️
src/app/backend/auth/handler.go 40.32% <66.66%> (+2.82%) ⬆️
src/app/frontend/login/component.js 91.3% <80%> (-1.38%) ⬇️
...p/backend/integration/metric/common/aggregation.go 89.23% <0%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d7067...1851091. Read the comment docs.

@bryk bryk self-requested a review June 11, 2018 07:28
Copy link
Contributor

@bryk bryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The continuous integration issue seems to be resolved. Thanks for the contribution!

@bryk bryk added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: onitake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ded3180 into kubernetes:master Jun 11, 2018
@udit2909
Copy link

udit2909 commented Aug 6, 2018

@floreks @bryk Can you please create a release for this pr. Would be very helpful :)

@onitake onitake deleted the feature/hide-skip-button branch August 23, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants