-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: display job as failed if job backoff limit has reached #3098
Conversation
/assign @bryk |
Codecov Report
@@ Coverage Diff @@
## master #3098 +/- ##
==========================================
- Coverage 54.23% 54.22% -0.01%
==========================================
Files 564 564
Lines 12209 12220 +11
==========================================
+ Hits 6621 6626 +5
- Misses 5332 5338 +6
Partials 256 256
Continue to review full report at Codecov.
|
Will look at it this Monday if no one else did before then.
…On Fri, Jul 6, 2018, 22:45 Alexander Matyushentsev ***@***.***> wrote:
Can someone please take a look? @konryd <https://github.com/konryd> ,
@rf232 <https://github.com/rf232>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3098 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADuJFt5X75mbi6xEw3vN354jizfZjEZCks5uD8yDgaJpZM4Ur-KE>
.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexmt, rf232 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull request resolves #2788: job list API returns an inferred job status; the job card component renders error icon if job status is failed.