Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: display job as failed if job backoff limit has reached #3098

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

alexmt
Copy link
Contributor

@alexmt alexmt commented Jun 18, 2018

Pull request resolves #2788: job list API returns an inferred job status; the job card component renders error icon if job status is failed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2018
@alexmt
Copy link
Contributor Author

alexmt commented Jun 18, 2018

/assign @bryk

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #3098 into master will decrease coverage by <.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   54.23%   54.22%   -0.01%     
==========================================
  Files         564      564              
  Lines       12209    12220      +11     
==========================================
+ Hits         6621     6626       +5     
- Misses       5332     5338       +6     
  Partials      256      256
Impacted Files Coverage Δ
src/app/frontend/job/list/card_component.js 90% <100%> (+1.11%) ⬆️
src/app/backend/resource/job/list.go 72.5% <70%> (-0.36%) ⬇️
src/app/backend/sync/secret.go 66.94% <0%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2dabdc...612b794. Read the comment docs.

@alexmt
Copy link
Contributor Author

alexmt commented Jul 6, 2018

Can someone please take a look? @konryd , @rf232

@rf232
Copy link
Contributor

rf232 commented Jul 6, 2018 via email

@rf232
Copy link
Contributor

rf232 commented Jul 9, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexmt, rf232

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit d1d99e5 into kubernetes:master Jul 9, 2018
@alexmt alexmt deleted the 2788-failed-jobs branch July 9, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs are not displayed as failed after reaching backoff limit
4 participants