-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for viewing completed/inactive CronJob jobs #3103
Conversation
/assign @danielromlein |
Codecov Report
@@ Coverage Diff @@
## master #3103 +/- ##
==========================================
+ Coverage 54.23% 54.25% +0.02%
==========================================
Files 564 564
Lines 12209 12254 +45
==========================================
+ Hits 6621 6648 +27
- Misses 5332 5346 +14
- Partials 256 260 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for the contribution!
@pengx17 Can you also review this and LGTM/comment? |
/LGTM, btw @jeefy I do not find changes related to regular Jobs. Do you think it is better to include these to Job detail pages as well? |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jeefy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the feedback/merge! @pengx17 This is to display jobs owned by a CronJob specifically. It wouldn't apply to a Job itself. If there are more use cases of jobs spawning other jobs (a la HPC workflow) it might make sense. It might be a good idea to eventually have the ability to display objects that have an OwnerRef of the currently-viewed object. That would probably solve this across the board. :) |
Hi all! This directly addresses #2786
I created an additional function that pulls only completed Jobs for a given CronJob.
Next I shimmed in "Inactive Jobs" in the CronJobDetail Type as well as in the Angular page under the "Active Jobs" card.
Tested locally via minikube (v1.10, v1.9, v1.8)
Let me know if there's anything I need to change or fix!