Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go dependencies #3157

Merged
merged 3 commits into from
Aug 9, 2018
Merged

chore: update go dependencies #3157

merged 3 commits into from
Aug 9, 2018

Conversation

pengx17
Copy link
Contributor

@pengx17 pengx17 commented Jul 19, 2018

This is a prerequisite for WIP pr #2980.
Since some of the dependencies are mismatch between sigs/application (there was recently a beta release for this pkg) and Dashboard, all related Kubernetes go-client dependencies are updated with standard dep operations.

I have go through some basic pages and it looks like the Dashboard can work well with the update.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 19, 2018
@pengx17
Copy link
Contributor Author

pengx17 commented Jul 19, 2018

/assign @maciaszczykm

@konryd

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #3157 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
+ Coverage   54.52%   54.52%   +<.01%     
==========================================
  Files         565      565              
  Lines       12397    12397              
==========================================
+ Hits         6759     6760       +1     
+ Misses       5376     5375       -1     
  Partials      262      262
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 89.23% <0%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed35fc...a288e2c. Read the comment docs.

@austbot
Copy link
Contributor

austbot commented Jul 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2018
@maciaszczykm maciaszczykm added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Aug 2, 2018
@maciaszczykm
Copy link
Member

Verified with k/1.9.9.

@maciaszczykm
Copy link
Member

Verified with k/1.10.0. Big thanks @pengx17!

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austbot, maciaszczykm, pengx17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2018
@maciaszczykm maciaszczykm mentioned this pull request Aug 9, 2018
6 tasks
@maciaszczykm maciaszczykm merged commit ffe4873 into kubernetes:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants