-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move logs icons to a menu #3766
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3766 +/- ##
=======================================
Coverage 47.14% 47.14%
=======================================
Files 171 171
Lines 7971 7971
Branches 62 62
=======================================
Hits 3758 3758
Misses 3972 3972
Partials 241 241 Continue to review full report at Codecov.
|
This looks awesome and I love the direction. Couple small thoughts:
If you can address those two behaviors this should get merged in quick. /assign |
@feloy There are some formatting nits that are causing the Travis job to fail. Please run When these nits get fixed this looks good to merge! |
Please rebase/merge master to fix the issues with the CI job. Sorry for the inconvenience. |
@feloy There's one more conflict that needs resolving. Everything else lgtm so hoping to merge this soon. Thanks! |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy, jeefy, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Here is my proposition to fix the issue #3754.
In the logs view, the toggle buttons are instead placed in a floating menu.