Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show tooltip timestamp on time hover across pages #3767

Merged
merged 6 commits into from
May 29, 2019
Merged

Show tooltip timestamp on time hover across pages #3767

merged 6 commits into from
May 29, 2019

Conversation

feloy
Copy link
Member

@feloy feloy commented Apr 27, 2019

Fixes #3631

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2019
@k8s-ci-robot k8s-ci-robot requested review from cupofcat and jeefy April 27, 2019 17:20
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 27, 2019
@codecov
Copy link

codecov bot commented Apr 27, 2019 •
edited
Loading

Codecov Report

Merging #3767 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3767      +/-   ##
==========================================
- Coverage   47.14%   46.94%   -0.21%     
==========================================
  Files         171      171              
  Lines        7971     7971              
  Branches       62       62              
==========================================
- Hits         3758     3742      -16     
- Misses       3972     3999      +27     
+ Partials      241      230      -11
Impacted Files Coverage Δ
src/app/frontend/common/pipes/relativetime.ts 25.58% <0%> (-30.24%) ⬇️
src/app/frontend/common/services/global/config.ts 80% <0%> (-10%) ⬇️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0420e4...9c04752. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2019
@feloy feloy force-pushed the feloy-dates branch 3 times, most recently from ead6652 to 9971ee7 Compare April 27, 2019 19:29
@feloy feloy changed the title WIP: Show tooltip timestamp on time hover across pages Show tooltip timestamp on time hover across pages Apr 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2019
@jeefy
Copy link
Member

jeefy commented Apr 28, 2019

This looks 💯

Small suggestion: Could you possibly the formatted times have some style that lets you know you can hover? Even as simple as a dotted underline would be great.

/assign

@jeefy
Copy link
Member

jeefy commented Apr 30, 2019

Changes look good.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
eloyekunle
eloyekunle reviewed Apr 30, 2019
View reviewed changes
Copy link
Contributor

@eloyekunle eloyekunle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@maciaszczykm
Copy link
Member

Please rebase/merge master to fix the issues with the CI job. Sorry for the inconvenience.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2019
@jeefy
Copy link
Member

jeefy commented May 13, 2019

Rebase looks good. @maciaszczykm PTAL

@jeefy
Copy link
Member

jeefy commented May 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, jeefy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe1737e into kubernetes:master May 29, 2019
@eloyekunle eloyekunle mentioned this pull request Sep 4, 2019
Closed
6 tasks
@feloy feloy mentioned this pull request Jan 6, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm left review comments

@eloyekunle eloyekunle eloyekunle left review comments

@cupofcat cupofcat Awaiting requested review from cupofcat

@jeefy jeefy Awaiting requested review from jeefy

Assignees

@jeefy jeefy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show tooltip timestamp on time hover across pages
5 participants
@feloy @jeefy @maciaszczykm @k8s-ci-robot @eloyekunle