Assume valid when name validation errors.

[bryk]

Addresses #373

[bryk]

@codegoblins

[bryk]

@codegoblins can you review?

[codecov-io]

Current coverage is 80.58%

Merging #393 into master will not affect coverage as of cb64c1e

@@            master    #393   diff @@
======================================
  Files           75      75       
  Stmts          613     613       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            494     494       
  Partial          0       0       
  Missed         119     119       

Review entire Coverage Diff as of cb64c1e

Powered by Codecov. Updated on successful CI builds.

[codegoblins]

With this patch I was able to create a service & RC from the deploy flow called 'runtest':

However, I am unable to do anything else from the dashboard e.g. edit pod count, view details:

It seems like kubernetes/kubernetes/21464 is the real culprit here. If we want to fix this from the frontend side, we're just pushing the problem further down the deployment/administration flow.

[bryk]

However, I am unable to do anything else from the dashboard e.g. edit pod count, view details:

True. You'll be able to access it when running the Dashboard inside a cluster.

[bryk]

It seems like kubernetes/kubernetes/21464 is the real culprit here. If we want to fix this from the frontend side, we're just pushing the problem further down the deployment/administration flow.

You're correct. The linked issue is the real problem. This PR, however, addresses problem with our UI where we assume that name is invalid when we cannot determine its correctness. I believe we should assume it is valid because potential problems will be caught later.

[codegoblins]

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[codegoblins]

Confirmed that the problem is nonexistant when running from within the cluster.

[maciaszczykm]

Should it be merged?

[bryk]

I say yes :) Merging.