Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help access dashboard with v2 #4101

Closed
wants to merge 1 commit into from
Closed

Help access dashboard with v2 #4101

wants to merge 1 commit into from

Conversation

feloy
Copy link
Member

@feloy feloy commented Jul 21, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: feloy
To complete the pull request process, please assign ianlewis
You can assign the PR to them by writing /assign @ianlewis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from konryd and olekzabl July 21, 2019 11:39
@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #4101 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4101      +/-   ##
==========================================
+ Coverage   46.35%   46.39%   +0.03%     
==========================================
  Files         194      194              
  Lines        8922     8922              
  Branches       83       83              
==========================================
+ Hits         4136     4139       +3     
+ Misses       4532     4528       -4     
- Partials      254      255       +1
Impacted Files Coverage Δ
src/app/backend/sync/secret.go 73.26% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7acabb2...13f1617. Read the comment docs.

maciaszczykm
maciaszczykm reviewed Jul 25, 2019
View reviewed changes
README.md
@@ -31,6 +31,12 @@ Now access Dashboard at:
[`http://localhost:8001/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/`](
http://localhost:8001/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/).

Or, if you are using the v2:

[`http://localhost:8001/api/v1/namespaces/kubernetes-dashboard/services/https:kubernetes-dashboard:/proxy/`](
Copy link
Member

@maciaszczykm maciaszczykm Jul 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no v2 mention anywhere else in this file. I'd rephrase:

**NOTE**: If you are using one of v2.0.0 beta releases then use: ...

Adding some link to the latest beta release might be good idea too.

@floreks @jeefy WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd have to add it also for latest v1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'd rather mention v2 only in the README and move v1 access part to the docs. We could only mention that if you want to use v1 follow this guide.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 22, 2019
@feloy feloy mentioned this pull request Jan 6, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks left review comments

@maciaszczykm maciaszczykm maciaszczykm left review comments

@konryd konryd Awaiting requested review from konryd

@olekzabl olekzabl Awaiting requested review from olekzabl

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@feloy @k8s-ci-robot @fejta-bot @floreks @maciaszczykm