Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean localization for Dashboard #4174

Merged
merged 3 commits into from
Aug 8, 2019

Conversation

seokho-son
Copy link
Member

@seokho-son seokho-son commented Aug 7, 2019

This PR is to initiate Korean localization for Dashboard.

This PR modifies (1) i18n/locale_conf.json, (2) package.json to add "ko" as a new localization language.
Also, the PR includes i18n/messages.ko.xlf that includes actual translation contents.

I am one of @kubernetes/sig-docs-ko-owners , and we are happy to know about new Kubernetes Dashboard v2.0.0 and provide localization for Korean !! (Thank you @shu-mutou for your guidance)

cc to sig-docs-ko-reviews for checking any major issues in the Korean translation.
(Please note that this PR is for initiation of Korean localization for Dashboard. I did my best for the translation, but if there is a major issue, please let me know :) )
/cc @kubernetes/sig-docs-ko-reviews

image

@k8s-ci-robot
Copy link
Contributor

Welcome @seokho-son!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 7, 2019
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #4174 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4174      +/-   ##
==========================================
+ Coverage   46.14%   46.18%   +0.03%     
==========================================
  Files         194      194              
  Lines        8999     8999              
  Branches       83       83              
==========================================
+ Hits         4153     4156       +3     
+ Misses       4591     4587       -4     
- Partials      255      256       +1
Impacted Files Coverage Δ
src/app/backend/sync/secret.go 73.26% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf21b6...02324d3. Read the comment docs.

@shu-mutou
Copy link
Contributor

Thank you for adding new l10n file! But a typo was found yesterday, and we need to refresh messages files now. Please wait #4173 merged. Then rebase to it, run npm run fix:i18n again and recheck your i18n file. Sorry for inconvinience.

@seokho-son
Copy link
Member Author

Thank you for adding new l10n file! But a typo was found yesterday, and we need to refresh messages files now. Please wait #4173 merged. Then rebase to it, run npm run fix:i18n again and recheck your i18n file. Sorry for inconvinience.

I got it. I will rebase this PR after #4173 is merged. Thank you.
In the meantime, I hope to get comments from reviewers :)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2019
@shu-mutou
Copy link
Contributor

#4173 was merged. Please rebase this PR. Thanks. 😉

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 8, 2019
</trans-unit>
<trans-unit id="4a4f46a2dcec36bd5c8c371ceee55c2226dec27f" datatype="html">
<source>Schedule</source>
<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo ("requestes") was fixed few days ago, so "trans-unit id" was changed. Please re-run npm run fix:i18n after rebasing, then check again this files. After running npm run fix:i18n, this typo will fixed and some "transunit" for new views will be added.

@seokho-son
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2019
@seokho-son
Copy link
Member Author

@shu-mutou Thank you. I applied the fixed typo and translated the associated target into Korean.

@shu-mutou
Copy link
Contributor

/lgtm
@seokho-son Great!! Thank you for addressing updates. If you have inconvinience about our i18n workflow or have ideas to improve, feel free to submit issue.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2019
@floreks
Copy link
Member

floreks commented Aug 8, 2019

Great work. Thanks!

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, seokho-son, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit eafca70 into kubernetes:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants