-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean localization for Dashboard #4174
Conversation
Welcome @seokho-son! |
Codecov Report
@@ Coverage Diff @@
## master #4174 +/- ##
==========================================
+ Coverage 46.14% 46.18% +0.03%
==========================================
Files 194 194
Lines 8999 8999
Branches 83 83
==========================================
+ Hits 4153 4156 +3
+ Misses 4591 4587 -4
- Partials 255 256 +1
Continue to review full report at Codecov.
|
Thank you for adding new l10n file! But a typo was found yesterday, and we need to refresh messages files now. Please wait #4173 merged. Then rebase to it, run |
I got it. I will rebase this PR after #4173 is merged. Thank you. |
#4173 was merged. Please rebase this PR. Thanks. 😉 |
26afe58
to
d65261a
Compare
i18n/messages.ko.xlf
Outdated
</trans-unit> | ||
<trans-unit id="4a4f46a2dcec36bd5c8c371ceee55c2226dec27f" datatype="html"> | ||
<source>Schedule</source> | ||
< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This typo ("requestes") was fixed few days ago, so "trans-unit id" was changed. Please re-run npm run fix:i18n
after rebasing, then check again this files. After running npm run fix:i18n
, this typo will fixed and some "transunit" for new views will be added.
/hold cancel |
@shu-mutou Thank you. I applied the fixed typo and translated the associated target into Korean. |
/lgtm |
Great work. Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, seokho-son, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is to initiate Korean localization for Dashboard.
This PR modifies (1) i18n/locale_conf.json, (2) package.json to add "ko" as a new localization language.
Also, the PR includes i18n/messages.ko.xlf that includes actual translation contents.
I am one of @kubernetes/sig-docs-ko-owners , and we are happy to know about new Kubernetes Dashboard v2.0.0 and provide localization for Korean !! (Thank you @shu-mutou for your guidance)
cc to sig-docs-ko-reviews for checking any major issues in the Korean translation.
(Please note that this PR is for initiation of Korean localization for Dashboard. I did my best for the translation, but if there is a major issue, please let me know :) )
/cc @kubernetes/sig-docs-ko-reviews