Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better sanitize function #4232

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Conversation

jeefy
Copy link
Member

@jeefy jeefy commented Aug 28, 2019

@k8s-ci-robot k8s-ci-robot requested a review from liggitt August 28, 2019 15:37
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2019
@floreks
Copy link
Member

floreks commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, jeefy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #4232 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4232      +/-   ##
==========================================
- Coverage      46%   45.99%   -0.02%     
==========================================
  Files         198      198              
  Lines        9271     9271              
  Branches      105      105              
==========================================
- Hits         4265     4264       -1     
- Misses       4746     4747       +1     
  Partials      260      260
Impacted Files Coverage Δ
src/app/frontend/common/pipes/safehtml.ts 71.42% <50%> (ø) ⬆️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c860be9...a6f580f. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 2fb062b into kubernetes:master Aug 28, 2019
@awly
Copy link

awly commented Sep 3, 2019

What versions of the dashboard does this affect?

@jeefy
Copy link
Member Author

jeefy commented Sep 3, 2019

@awly From testing, 2.0.0-beta1 through 2.0.0-beta3.

Versions before weren't affected and 2.0.0-beta4 was cut shortly after this PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants