-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for plugin development #4276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4276 +/- ##
==========================================
- Coverage 46.59% 46.56% -0.03%
==========================================
Files 200 200
Lines 9373 9365 -8
Branches 105 105
==========================================
- Hits 4367 4361 -6
+ Misses 4738 4735 -3
- Partials 268 269 +1
Continue to review full report at Codecov.
|
Could you add link for this into https://github.com/kubernetes/dashboard/blob/master/docs/README.md ? |
Related to #4008. |
@shu-mutou Should this be mentioned under a separate category or under Developer Guide? |
@ajatprabha I think this should be described for third party that includes both of user and developer. |
/lgtm It's good as a first step. I'd like to have more infor about how to write plugins, what we can use, even some samples with screenshots showing the active plugin in the UI. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajatprabha, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
> Note: The backend reads the compiled plugin source from a ConfigMap and we need to create that also. | ||
|
||
### Creating ConfigMap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubernetes configmap has size limitation, (<=1MB), so the compiled plugin javascript file should not exceed 1MB. That is the limitation of this plugin solution, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right. We can look into other ways to obtain the compiled plugin file instead of just configmap. We wanted to keep dashboard stateless and using configmaps was the easiest way to tackle this for now.
No description provided.