Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph refresh on namespace change #4378

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

floreks
Copy link
Member

@floreks floreks commented Oct 3, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 3, 2019
@k8s-ci-robot k8s-ci-robot requested review from cheld and mhenc October 3, 2019 10:01
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 3, 2019
@floreks floreks force-pushed the fix/graph-refresh branch from 587265e to 3333e86 Compare October 3, 2019 14:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #4378 into master will increase coverage by 0.11%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
+ Coverage   46.62%   46.74%   +0.11%     
==========================================
  Files         200      200              
  Lines        9374     9380       +6     
  Branches      105      107       +2     
==========================================
+ Hits         4371     4385      +14     
+ Misses       4734     4721      -13     
- Partials      269      274       +5
Impacted Files Coverage Δ
.../app/frontend/common/components/graph/component.ts 79.31% <75%> (+27.13%) ⬆️
.../frontend/common/components/graphcard/component.ts 55% <0%> (-15%) ⬇️
src/app/frontend/common/components/graph/helper.ts 41.93% <0%> (+19.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8b44c...3333e86. Read the comment docs.

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 86c0006 into kubernetes:master Oct 3, 2019
@maciaszczykm maciaszczykm deleted the fix/graph-refresh branch October 3, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants