-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric graphs to remaining views #4449
Conversation
…yments list, node list, replica set list and stateful sets list pages. Part of kubernetes#3866.
Welcome @wjywbs! |
/assign @maciaszczykm |
Codecov Report
@@ Coverage Diff @@
## master #4449 +/- ##
=========================================
+ Coverage 46.67% 46.7% +0.03%
=========================================
Files 200 200
Lines 9376 9373 -3
Branches 107 107
=========================================
+ Hits 4376 4378 +2
+ Misses 4727 4721 -6
- Partials 273 274 +1
Continue to review full report at Codecov.
|
Is it ready for a review? |
Yes. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, wjywbs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will you prepare the rest of the graphs? |
I did all the straight forward ones. The rest may need some fixes on the backend like #4145, and I'm not working on that now. |
Part of #3866.