Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric graphs to remaining views #4449

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Conversation

wjywbs
Copy link
Contributor

@wjywbs wjywbs commented Oct 23, 2019

Part of #3866.

…yments list, node list, replica set list and stateful sets list pages.

Part of kubernetes#3866.
@k8s-ci-robot
Copy link
Contributor

Welcome @wjywbs!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2019
@wjywbs
Copy link
Contributor Author

wjywbs commented Oct 23, 2019

/assign @maciaszczykm

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #4449 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4449      +/-   ##
=========================================
+ Coverage   46.67%   46.7%   +0.03%     
=========================================
  Files         200     200              
  Lines        9376    9373       -3     
  Branches      107     107              
=========================================
+ Hits         4376    4378       +2     
+ Misses       4727    4721       -6     
- Partials      273     274       +1
Impacted Files Coverage Δ
src/app/frontend/overview/component.ts 78.57% <ø> (+7.98%) ⬆️
src/app/backend/sync/secret.go 73.26% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b470a3b...4013cea. Read the comment docs.

@floreks floreks changed the title Add metric graphs on node detail, pod detail, daemon sets list, deployments list, node list, replica set list and stateful sets list pages. Add metric graphs to remaining views Oct 23, 2019
@maciaszczykm
Copy link
Member

Is it ready for a review?

@wjywbs
Copy link
Contributor Author

wjywbs commented Oct 24, 2019

Yes.

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, wjywbs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@maciaszczykm
Copy link
Member

Will you prepare the rest of the graphs?

@k8s-ci-robot k8s-ci-robot merged commit 8a4f394 into kubernetes:master Oct 24, 2019
@wjywbs wjywbs deleted the graph branch October 24, 2019 16:44
@wjywbs
Copy link
Contributor Author

wjywbs commented Oct 24, 2019

I did all the straight forward ones. The rest may need some fixes on the backend like #4145, and I'm not working on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants